Skip to content

Potential fix for code scanning alert no. 2: Open URL redirect #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grokify merged 1 commit into from
Mar 7, 2026
Merged

Potential fix for code scanning alert no. 2: Open URL redirect #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions oauth2/handlers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,6 +744,22 @@

// Note: redirect_uri is validated against client.RedirectURIs in handleAuthorizationGet
// BEFORE this function is called. External URIs are allowed if they're registered.
//
// As a defense-in-depth measure, ensure we only redirect to relative URLs or to the
// same host as the current request. This prevents open redirects if this helper is
// ever called with an unvalidated absolute URL.
if u.IsAbs() && u.Hostname() != "" {
// Extract hostname from r.Host (which may include a port).
requestHost := r.Host
if h, _, splitErr := strings.Cut(requestHost, ":"); splitErr == nil {

Check failure on line 754 in oauth2/handlers.go

View workflow job for this annotation

GitHub Actions / lint / lint 

invalid operation: splitErr == nil (mismatched types bool and untyped nil) (typecheck)

Check failure on line 754 in oauth2/handlers.go

View workflow job for this annotation

GitHub Actions / ci / test (1.26.x, macos-latest) 

invalid operation: splitErr == nil (mismatched types bool and untyped nil)

Check failure on line 754 in oauth2/handlers.go

View workflow job for this annotation

GitHub Actions / ci / test (1.26.x, ubuntu-latest) 

invalid operation: splitErr == nil (mismatched types bool and untyped nil)

Check failure on line 754 in oauth2/handlers.go

View workflow job for this annotation

GitHub Actions / ci / test (1.25.x, ubuntu-latest) 

invalid operation: splitErr == nil (mismatched types bool and untyped nil)

Check failure on line 754 in oauth2/handlers.go

View workflow job for this annotation

GitHub Actions / ci / test (1.25.x, macos-latest) 

invalid operation: splitErr == nil (mismatched types bool and untyped nil)
requestHost = h
}

if !strings.EqualFold(u.Hostname(), requestHost) {
s.renderLoginError(w, description)
return
}
}

q := u.Query()
q.Set("error", errCode)
Expand Down
Loading