aws: support bare-POST token generation + typed models (onboarding 1/3) - #5
Draft
droth-plerion wants to merge 1 commit into
Draft
droth-plerion wants to merge 1 commit into
droth-plerion wants to merge 1 commit into
Conversation
generate_token now takes Option<&str>: Some(id) keeps the existing integration-scoped behavior (aws generate-token is unchanged), None issues the bare POST that mints an onboarding token for registering a new AWS account. New typed envelope models for the three AWS endpoints; the raw subcommands keep returning serde_json::Value so their output is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 2c1bffa)
Author
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 of 3 in the
integrations add awsseries (this → onboarding engine → CLI command). Jira: PL-5466 · APPP-15.What
generate_tokentakesOption<&str>:Some(id)keeps today's integration-scoped behavior — theplerion aws generate-token --integration-idsubcommand is byte-for-byte unchanged — whileNoneissues the bare POST that mints an onboarding token for registering a new AWS account (per docs.plerion.com; the CloudFormation console flow uses the same call).models/aws.rs), used by the upcoming onboarding engine. The rawplerion aws ...subcommands keep returningserde_json::Value, so their passthrough output is untouched. (Temporary module-leveldead_codeallow until the binary consumes them in PR 3.)Why split out
No behavior change; reviewable in minutes; unblocks the engine PR.
Testing
mockito asserts both request bodies:
{"integrationId":"..."}forSome, empty body forNone. Existing tests unchanged.Ask for eng: confirm against a dev tenant that the bare
POST /v1/tenant/integrations/tokenmints an onboarding token — mockito can't prove the API contract.🤖 Generated with Claude Code