♻️ refactor: remove Compat methods in favour on their implementation

[gaeljw]

Pull Request Checklist

• Have you read How to write the perfect pull request?
• Have you read through the contributor guidelines?
• Have you squashed your commits?
• Have you added copyright headers to new files?
• Have you checked that both Scala and Java APIs are updated?
• Have you updated the documentation for both Scala and Java sections?
• Have you added tests for any changed functionality?

Purpose

Clean code.

Background Context

This code was different when we were cross building to Scala 2.11/2.12 but not required anymore.

[Copilot]

Pull request overview

This PR removes the internal anorm.Compat helper layer and rewrites call sites to use standard library APIs directly (e.g., right-biased Either, lazyZip, collection conversions), reflecting the project’s current Scala 2.13/3 baseline.

Changes:

• Replaced Compat collection/type aliases (Trav, LazyLst) with Iterable/LazyList and inlined helper methods (rightMap, rightFlatMap, toMap, etc.).
• Updated parsing/mapping code paths to use direct Either and collection operations.
• Removed core/src/main/scala/anorm/Compat.scala and added MiMa filters for the missing Compat classes.

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
core/src/main/scala/anorm/ToStatementMisc.scala	Switch stream/traversable handling from Compat.* aliases to LazyList/Iterable.
core/src/main/scala/anorm/ToSql.scala	Same refactor for SQL fragment generation over streams/iterables.
core/src/main/scala/anorm/TopLevelDefinitions.scala	Replace Compat Java-enum iterator helper with scala.jdk.CollectionConverters usage.
core/src/main/scala/anorm/SqlParser.scala	Inline Either right-bias operations (remove Compat.rightFlatMap).
core/src/main/scala/anorm/Row.scala	Replace Compat.lazyZip/toMap helpers with direct lazyZip and .to(Map).
core/src/main/scala/anorm/MetaData.scala	Replace Compat.toMap/toFlatMap with view + .to(Map) equivalents.
core/src/main/scala/anorm/Cursor.scala	Replace Compat.lazyZip usage with direct lazyZip.
core/src/main/scala/anorm/Compat.scala	Removed the Compat object entirely.
core/src/main/scala/anorm/Column.scala	Inline Either.map/flatMap where Compat.rightMap/rightFlatMap was used.
core/src/main/scala/anorm/BatchSql.scala	Replace Compat.Trav with Iterable in public/internal APIs.
core/src/main/scala-3/anorm/macros/ToParameterListImpl.scala	Remove unused Compat import after refactor.
core/src/main/scala-3/anorm/macros/Inspect.scala	Remove unused Compat import after refactor.
core/src/main/scala-2/anorm/macros/ToParameterListImpl.scala	Replace Compat helpers with view.mapValues, view.collect, .to(Map).
core/src/main/scala-2/anorm/macros/Inspect.scala	Replace Compat.Trav with Iterable and direct lazyZip.
build.sbt	Add MiMa excludes for removed anorm.Compat classes.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.