Skip to content

Add shader defines for prepass to support alpha test and dithered opacity #8606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slimbuck merged 2 commits into from
Apr 17, 2026
+10 −1
Merged

Add shader defines for prepass to support alpha test and dithered opacity #8606

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c575330
latest
slimbuck Apr 16, 2026
0264529
latest
slimbuck Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/scene/shader-lib/programs/lit-shader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
SPRITE_RENDERMODE_SLICED, SPRITE_RENDERMODE_TILED, shadowTypeInfo, SHADER_PREPASS,
lightTypeNames, lightShapeNames, spriteRenderModeNames, fresnelNames, blendNames, lightFalloffNames,
cubemaProjectionNames, specularOcclusionNames, reflectionSrcNames, ambientSrcNames,
ditherNames,
REFLECTIONSRC_NONE
} from '../../constants.js';
import { ChunkUtils } from '../chunk-utils.js';
Expand Down Expand Up @@ -513,6 +514,13 @@ class LitShader {
this._setupLightingDefines(hasAreaLights, options.clusteredLightingEnabled);
}

preparePrepassPass() {
const { options } = this;
this.fDefineSet(options.alphaTest, 'LIT_ALPHA_TEST');
this.fDefineSet(true, 'LIT_BLEND_TYPE', blendNames[options.blendType]);
Comment thread
slimbuck marked this conversation as resolved.
Outdated
this.fDefineSet(true, 'STD_OPACITY_DITHER', ditherNames[options.opacityShadowDither]);
}

prepareShadowPass() {

const { options } = this;
Expand Down Expand Up @@ -548,8 +556,10 @@ class LitShader {
this.includes.set('frontendDeclPS', frontendDecl ?? '');
this.includes.set('frontendCodePS', frontendCode ?? '');

if (options.pass === SHADER_PICK || options.pass === SHADER_PREPASS) {
if (options.pass === SHADER_PICK) {
// nothing to prepare currently
} else if (options.pass === SHADER_PREPASS) {
this.preparePrepassPass();
} else if (this.shadowPass) {
this.prepareShadowPass();
} else {
Expand Down