schedulingpb: add split reason to ask batch split request#1459
Merged
Conversation
Signed-off-by: lhy1024 <admin@liudos.us>
bufferflies
approved these changes
May 9, 2026
|
@bufferflies: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
JmPotato
approved these changes
May 11, 2026
rleungx
approved these changes
May 11, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bufferflies, JmPotato, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lhy1024
added a commit
to lhy1024/kvproto
that referenced
this pull request
May 25, 2026
Signed-off-by: lhy1024 <19542290+lhy1024@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
PD's scheduling service needs to carry the split reason for
AskBatchSplitRequest, so MCS scheduling can preserve the same split semantics as the existing PD path. Encoding this business field in gRPC metadata is less appropriate than making it part of the protocol.Related to tikv/pd#10648.
What is changed and how does it work?
This PR adds
pdpb.SplitReason reason = 4toschedulingpb.AskBatchSplitRequest, matching the existingpdpb.AskBatchSplitRequestfield. The Go protobuf code andscripts/proto.lockare regenerated accordingly.Check List
Tests:
scripts/proto_format.sh --checkprotolock status -lockdir=scripts -protoroot=protoGO111MODULE=on go test ./pkg/schedulingpbGO111MODULE=on go build ./pkg/...cargo checkcargo check --no-default-features --features prost-codec