Repository navigation
Validation thresholds in compareScenarios - #154
Conversation
There was a problem hiding this comment.
This implementation goes for a hard integration into createLinePlots (via an optional parameter, though) instead of adding another custom plot format building on top of createLinePlots.
I assume the motivation is avoiding adjustments of numerous line plots in the compScen markdowns? I guess this is ok if we want to have the funnels/bands in all the line plots per default.
Has this been discussed/decided with key stakeholders like Gunnar, Robert and Lavinia?
Yes, the integration was an explicit wish of Gunnar and yesterday Lavinia agreed on using it as default. Doing it via createLinePlots is the only feasable option in my opinion, because which variables have thresholds is something that changes a lot over time and depending on the validationConfig used and having to adjust rmds accordingly is quite the headache. |
See remindmodel/remind#2493