Skip to content

Validation thresholds in compareScenarios - #154

Merged
pweigmann merged 5 commits into
pik-piam:masterfrom
pweigmann:cs-vs
Oct 8, 2026
Merged

pweigmann merged 5 commits into
pik-piam:masterfrom
pweigmann:cs-vs

Conversation

@pweigmann

Copy link
Copy Markdown
Contributor

Comment thread tests/testthat/Rplots.pdf Outdated

@fbenke-pik fbenke-pik left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation goes for a hard integration into createLinePlots (via an optional parameter, though) instead of adding another custom plot format building on top of createLinePlots.

I assume the motivation is avoiding adjustments of numerous line plots in the compScen markdowns? I guess this is ok if we want to have the funnels/bands in all the line plots per default.

Has this been discussed/decided with key stakeholders like Gunnar, Robert and Lavinia?

Comment thread tests/testthat/test-createLinePlots.R Outdated
@pweigmann

Copy link
Copy Markdown
Contributor Author

This implementation goes for a hard integration into createLinePlots (via an optional parameter, though) instead of adding another custom plot format building on top of createLinePlots.

I assume the motivation is avoiding adjustments of numerous line plots in the compScen markdowns? I guess this is ok if we want to have the funnels/bands in all the line plots per default.

Has this been discussed/decided with key stakeholders like Gunnar, Robert and Lavinia?

Yes, the integration was an explicit wish of Gunnar and yesterday Lavinia agreed on using it as default.

Doing it via createLinePlots is the only feasable option in my opinion, because which variables have thresholds is something that changes a lot over time and depending on the validationConfig used and having to adjust rmds accordingly is quite the headache.

@fbenke-pik
fbenke-pik self-requested a review October 8, 2026 09:26
@pweigmann
pweigmann merged commit 41a81eb into pik-piam:master Oct 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants