Repository navigation
replace gdxrrw - #153
Merged
Merged
replace gdxrrw#153
Conversation
pascal-sauer
left a comment
pascal-sauer
left a comment
There was a problem hiding this comment.
piamutils::readGdxToDf replaces the removed dataframeFromGdx?
| #' iteration order, e.g. pathToGdx[1] should hold data for the first iteration, pathToGdx[2] for the | ||
| #' second iteration etc. If the path to a folder is given the fulldata gdx files in it are used. | ||
| #' @param ... Additional arguments passed to gdxrrw::rgdx. | ||
| #' @param ... Additional arguments passed to gamstransfer::readGDX. |
There was a problem hiding this comment.
Suggested change
| #' @param ... Additional arguments passed to gamstransfer::readGDX. | |
| #' @param ... Additional arguments passed to piamutils::readGdxToDf. |
| #' etc. The last column will always be the actual value column called <symbolName>. | ||
| #' @author Pascal Führlich | ||
| #' @seealso \code{\link{mipIterations}}, \code{\link{dataframeFromGdx}} | ||
| #' @author Pascal Sauer |
|
|
||
| ggname <- function(x) { | ||
| if (class(x) != "character") { | ||
| if ("character" != class(x)) { |
Contributor
Author
There was a problem hiding this comment.
To fix a note halfheartedly. I changed it again with a proper fix.
| testFile <- file.path(tempDir, "fulldata.gdx") | ||
| gdxrrw::wgdx.lst(testFile, testData) | ||
| piamutils::writeDfToGDXparameter(testData, gdxFileName = testFile, | ||
| paramName = "testSymbolName", valueCol = "testSymbolName") |
pascal-sauer
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
piamutils::readGdxToDfusing gamstransfercreateMultiLinePlotsByVariable,scenToolMAgPIE,scenToolscratchBar.R, as is doesn't seem to be used anymore (checked via reposearch)