Repository navigation
Import ggplot2 theme_void in createLinePlots - #152
Merged
Merged
Conversation
createLinePlots draws an empty placeholder plot (ggplot() + theme_void()) for scenarios with no data, but theme_void was never imported, so the call failed with "could not find function theme_void" under R CMD check, where ggplot2 is not attached. Add the missing @importFrom.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
createLinePlots()draws an empty placeholder plot (ggplot() + theme_void()) for scenarios with no data (R/showLinePlots.R:156,198), buttheme_voidwas never added to the ggplot2 imports (the NAMESPACE hastheme,theme_bw,theme_minimal, but nottheme_void). Under R CMD check, where ggplot2 is not attached, the bare call fails:This breaks R CMD check for any package that tests a mip line plot with a missing-data scenario. It surfaced in pik-piam/piamInterfaces CI (
test-plotIntercomparison), but it is not specific to that package. Introduced inde3133c("Minor performance tweaks").Change
Add
@importFrom ggplot2 theme_voidtocreateLinePlots;buildLibraryadds the matching NAMESPACE entry. One-line fix, tests pass.