Wrap strings passed to libzip with zip_source_function_create()#21659
Wrap strings passed to libzip with zip_source_function_create()#21659tstarling wants to merge 1 commit intophp:masterfrom
Conversation
Wrap strings passed to libzip with zip_source_function_create() instead of using zip_source_buffer_create(). This allows us to make the string writable, and simplifies memory management.
tstarling
force-pushed
the
zip_source_function_create
branch
from
8527d42 to
bb06b21
Compare
|
Everything looked correct on an implementation level yesterday - I'll come back to this with fresh eyes in a few days and confirm that nothing looks off, and then merge it |
DanielEScherzer
left a comment
DanielEScherzer
left a comment
There was a problem hiding this comment.
Looks good to me - question for Ben about adding license headers for new files between now and when #20904 merges, but otherwise makes sense
| +----------------------------------------------------------------------+ | ||
| | Copyright (c) The PHP Group | | ||
| +----------------------------------------------------------------------+ | ||
| | This source file is subject to version 3.01 of the PHP license, | |
There was a problem hiding this comment.
CC @ramsey - should this be added with the new license header for the new license? Or should it be added with the 3.01 license and be switched in your migration patch?
There was a problem hiding this comment.
You may go ahead and use the new license header. Otherwise, if it’s merged as-is before I merge the license update PR, I’ll try to catch it.
|
@tstarling do you have merge rights? I see that you are an org member |
4 participants
Wrap strings passed to libzip with zip_source_function_create() instead of using zip_source_buffer_create(). This allows us to make the string writable, and simplifies memory management.
Split from #21497 as requested by @DanielEScherzer