Skip to content

fix: bottom panel tab bar infinite switch flicker #2813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abose merged 2 commits into from
Apr 16, 2026
+22 −5
Merged

fix: bottom panel tab bar infinite switch flicker #2813

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e85f48f
fix: bottom panel tab bar infinite switch flicker
abose Apr 13, 2026
f1c8d0d
fix: infinite flicker in mac in bottom panel tab bar due to size chan…
abose Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions src/view/PanelView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,13 +365,28 @@ define(function (require, exports, module) {
/** @type {jQueryObject} Overflow dropdown button */
let _$overflowBtn = null;

let _checkTabOverflowTimer = null;

function _checkTabOverflow() {
// Coalesce multiple calls (e.g. rapid tab adds) and defer to the
// next frame so that measurements happen after layout settles.
if (_checkTabOverflowTimer) {
cancelAnimationFrame(_checkTabOverflowTimer);
}
_checkTabOverflowTimer = requestAnimationFrame(_doCheckTabOverflow);
}

function _doCheckTabOverflow() {
_checkTabOverflowTimer = null;
if (!_$tabBar) {
return;
}
// Remove collapsed state first to measure true width

// Remove collapsed state first to measure true width.
// Use a 1px tolerance to avoid sub-pixel rounding flicker at
// boundary sizes (e.g. scrollWidth 678 vs clientWidth 677).
_$tabBar.removeClass("bottom-panel-tabs-collapsed");
const isOverflowing = _$tabsOverflow[0].scrollWidth > _$tabsOverflow[0].clientWidth;
const isOverflowing = _$tabsOverflow[0].scrollWidth > _$tabsOverflow[0].clientWidth + 1;
_$tabBar.toggleClass("bottom-panel-tabs-collapsed", isOverflowing);

// Check if still overflowing after collapse
Expand Down Expand Up @@ -853,9 +868,11 @@ define(function (require, exports, module) {
_toggleMaximize();
});

// Re-check tab overflow when the tab bar resizes (e.g. window resize)
const tabBarResizeObserver = new ResizeObserver(_checkTabOverflow);
tabBarResizeObserver.observe(_$tabsOverflow[0]);
// Observe the outer tab bar container so that only external resizes
// (e.g. window resize, plugin panel open/close) trigger a re-check.
// Observing _$tabsOverflow would cause an infinite loop in WebKit
// because _checkTabOverflow toggles classes that change its size.
new ResizeObserver(_checkTabOverflow).observe(_$tabBar[0]);

// Restore maximize state from preferences (survives reload).
_isMaximized = PreferencesManager.getViewState(PREF_BOTTOM_PANEL_MAXIMIZED) === true;
Expand Down
Loading