Skip to content

Foolproof sitepackages_dir_cmd, and raise error when it fails - #210

Open
ashwinvis wants to merge 1 commit into
pew-org:masterfrom
ashwinvis:fix/py37-sitepackages-dir
Open

ashwinvis wants to merge 1 commit into
pew-org:masterfrom
ashwinvis:fix/py37-sitepackages-dir

Conversation

@ashwinvis

Copy link
Copy Markdown
Contributor

Fixes #209

@ghost ghost mentioned this pull request Feb 26, 2020
@ghost

ghost commented Feb 26, 2020

Copy link
Copy Markdown

I ran into this today. I'd really like to see this fix applied, since it seems to break my current workflow.

@tjanez tjanez mentioned this pull request Aug 6, 2020
@pfmoore

pfmoore commented Aug 6, 2020

Copy link
Copy Markdown
Collaborator

@ashwinvis Are you still interested in this? The appveyor tests are failing, which should be looked at.

@ashwinvis

Copy link
Copy Markdown
Contributor Author

I can update the PR. Seems like #214 is fixing the CI, so I can rebase the branch if it will be merged. Sounds good?

@pfmoore

pfmoore commented Aug 6, 2020

Copy link
Copy Markdown
Collaborator

Sure, if that works I'm fine with it. The error in question is "ImportError: No module named pew._utils" which seems a bit more fundamental, though (although I don't see how it relates to this PR).

@pfmoore

pfmoore commented Aug 6, 2020

Copy link
Copy Markdown
Collaborator

FWIW, I just tested master on my local (Windows) PC, and I see the test failures that #214 is addressing, but not the pew._utils one. But I was testing with Python 3.8, not Python 2.7, so maybe it's something Python 2 specific.

Ultimately, I'm happy to approve this PR if the tests pass, but I can't make the decision to accept a PR with test failures, sorry.

@ashwinvis

Copy link
Copy Markdown
Contributor Author

Can you retrigger the Appveyor CI - it could be something to do with their Python build / environment a year ago, which hopefully got fixed now.

@pfmoore

pfmoore commented Aug 6, 2020

Copy link
Copy Markdown
Collaborator

The only way I have of doing that is to close & reopen the PR, which I'll do. I don't have admin access to the Appveyor setup.

@pfmoore pfmoore closed this Aug 6, 2020
@pfmoore pfmoore reopened this Aug 6, 2020
@pfmoore

pfmoore commented Aug 6, 2020

Copy link
Copy Markdown
Collaborator

Sigh, that looks even worse 🙁

I don't have much more time to spend on this right now. Looks like there's some not-insignificant bitrot to address here :-( Probably something to pick up first on #218...

@ashwinvis
ashwinvis force-pushed the fix/py37-sitepackages-dir branch from aed9c40 to 2d9e18a Compare October 14, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Foolproof sitepackages_dir and related commands

2 participants