Skip to content

Added Decimal to numeric types #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juarezr merged 2 commits into from
Oct 15, 2021
Merged

Added Decimal to numeric types #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02e4487
Added Decimal to numeric_types by default.
blais Oct 6, 2021
aa37203
Modified test for numeric types.
blais Oct 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions petl/compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,10 @@
if PY2:
from itertools import ifilter, ifilterfalse, imap, izip, izip_longest
from string import maketrans
from decimal import Decimal
string_types = basestring,
integer_types = int, long
numeric_types = bool, int, long, float
numeric_types = bool, int, long, float, Decimal
text_type = unicode
binary_type = str
from urllib2 import urlopen
Expand All @@ -40,13 +41,14 @@
imap = map
izip = zip
xrange = range
from decimal import Decimal
from itertools import filterfalse as ifilterfalse
from itertools import zip_longest as izip_longest
from functools import reduce
maketrans = str.maketrans
string_types = str,
integer_types = int,
numeric_types = bool, int, float
numeric_types = bool, int, float, Decimal
class_types = type,
text_type = str
binary_type = bytes
Expand Down
5 changes: 3 additions & 2 deletions petl/test/test_comparison.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@


from datetime import datetime
from decimal import Decimal


from petl.test.helpers import eq_
Expand Down Expand Up @@ -29,9 +30,9 @@ def test_comparable():
eq_(e, a)

# mixed numeric
d = [3., 1, 2.5]
d = [3., 1, 2.5, Decimal('1.5')]
a = sorted(d, key=Comparable)
e = [1, 2.5, 3.]
e = [1, Decimal('1.5'), 2.5, 3.]
eq_(e, a)

# mixed numeric and bool
Expand Down