Bugfix/sharding module fix#1713
Open
Orrison wants to merge 6 commits into
Open
Conversation
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
Signed-off-by: Kevin Ullyott <kevin.ullyott@canyongbs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
Resolve an issue with sharding tests in a repo that has tests in non-standard tests directories (such as a repo using modular approaches, more details in the related issue)
In my tests I actually test the sharding functionality to make sure it is all working so it ends up actually generating a
tests/.pest/shards.jsonfile. Which is why during theafterAllof the test Iunlinkit.This is fine now, but will be problematic and weird if Pest itself ever wants to shard it's own tests.
So I just wanted to ask if this was acceptable for now? If not, my thought was I could also add to this PR a new option to override the path
shards.jsonis written to.As maybe someone at some point would want that and it would allow us to point these tests to generate the file somewhere we can
.gitignoreit.Related:
#1711