fix: add tests without explicit group to 'default' group#1712
Open
YoussefMansour9 wants to merge 1 commit into
Open
fix: add tests without explicit group to 'default' group#1712YoussefMansour9 wants to merge 1 commit into
YoussefMansour9 wants to merge 1 commit into
Conversation
Fixes pestphp#1602 - Running pest --group=default now correctly runs Pest tests that don't have an explicit group, matching PHPUnit's behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1602 - Running pest --group=default now correctly runs Pest tests that don't have an explicit group, matching PHPUnit's behavior.
What happened
When running
./vendor/bin/pest --group=default, zero tests were executed, even though there were Pest tests without explicit groups.Root cause
PHPUnit treats tests without an explicit @group annotation as being in the "default" group. However, Pest tests created with
test()orit()didn't have any group assigned, so --group=default found nothing.Solution
Add tests without an explicit group to the "default" group in TestRepository, matching PHPUnit's behavior.