consistent sharding logic when no shards file#1710
Open
moshe-autoleadstar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
without the file:
1/3 = a,b,c;2/3 = d,e,f;3/3 = g,h,iwith the file (empty):
1/3 = a,d,g;2/3 = b,e,h;3/3 = c,f,ithis PR makes the logic consistent so that without the file will work similar to an empty file (the second option above). this also helps balance the shards out of the box on standard projects as generally projects will have longer tests grouped together and shorter tests grouped together. for example when
a,b,c,d,e,f,g,h,i, usually it will be something likea,b,care faster,d,e,f,gare normal,h,iare slower.Related: