feat: convert namespace-style arguments to file paths in pest binary#1705
Open
florianraith wants to merge 1 commit into
Open
feat: convert namespace-style arguments to file paths in pest binary#1705florianraith wants to merge 1 commit into
florianraith wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
Allow namespaces to be accepted as path arguments in the binary.
Why would we want this?
When running the full test suite and a single test fails, you naturally want to re-run that test in isolation to debug it. The problem is that the test output shows namespaces (e.g.
Tests\Unit\TestName), not file paths. Currently, you can't just copy and paste that namespace into the pest command -- you have to manually convert it into a path first.What does this PR do?
When an argument contains a backslash (
\), it is treated as a namespace and converted into a file path by:DIRECTORY_SEPARATOR.phpsuffixTeststotests)The conversion only kicks in if the argument doesn't already resolve as a valid path, so existing behavior is unaffected.
(Sorry for the somewhat bloated terminal output and docker command, also not quite sure why the output is different when running the test in isolation)