Skip to content

fix: nested dataset discovery and parallel invalid-dataset reporting#1655

Merged
nunomaduro merged 3 commits into
pestphp:4.xfrom
stsepelin:fix/parallel-empty-suite-reporting
Apr 10, 2026
Merged

fix: nested dataset discovery and parallel invalid-dataset reporting#1655
nunomaduro merged 3 commits into
pestphp:4.xfrom
stsepelin:fix/parallel-empty-suite-reporting

Conversation

@stsepelin
Copy link
Copy Markdown
Contributor

What:

  • Bug Fix
  • New Feature

Description:

This PR follows up on #1427 and fixes two related problems in Pest's parallel execution flow.

First, it fixes nested dataset discovery for datasets stored in nested Datasets/ directories, addressing #1121.

Second, it fixes parallel reporting when a dataset is invalid or missing, so these cases are surfaced correctly as failures rather than being lost in the summary, addressing #1185.

The PR also adds regression coverage for both scenarios and keeps the success snapshot coverage in place with a lower memory limit for the visual snapshot test.

Related:

Comment thread tests/Visual/Success.php
@nunomaduro nunomaduro merged commit 8a83a1a into pestphp:4.x Apr 10, 2026
@stsepelin stsepelin deleted the fix/parallel-empty-suite-reporting branch April 10, 2026 11:03
@thomas-0816
Copy link
Copy Markdown

thomas-0816 commented Apr 10, 2026

Thank You!
I guess the changes in src/Support/StateGenerator.php should fix #1462 and #1463 .

@stsepelin Should these methods from https://github.com/sebastianbergmann/phpunit/blob/main/src/Runner/TestResult/TestResult.php also be handled in src/Support/StateGenerator.php ?

  • public function testRunnerTriggeredDeprecationEvents() // added in phpunit 12
  • public function testRunnerTriggeredNoticeEvents() // added in phpunit 12
  • public function testRunnerTriggeredWarningEvents() // added in phpunit 12
  • public function testSuiteSkippedEvents()
  • public function errors()

@nunomaduro
Copy link
Copy Markdown
Member

@thomas-0816 all of them.

@stsepelin
Copy link
Copy Markdown
Contributor Author

Thanks for the merge!

Opened a follow-up PR to handle the remaining PHPUnit\TestRunner\TestResult\TestResult methods you mentioned
(testRunnerTriggered{Deprecation,Notice,Warning}Events, testSuiteSkippedEvents, errors): #1683.

That also covers the "missing implementations in StateGenerator.php"
part of #1462.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot use Datasets in subfolders

3 participants