fix: merge .percy.yml config options with snapshot options for serializeDOM#223
Open
rishigupta1599 wants to merge 1 commit into
Open
fix: merge .percy.yml config options with snapshot options for serializeDOM#223rishigupta1599 wants to merge 1 commit into
rishigupta1599 wants to merge 1 commit into
Conversation
…izeDOM Config options from .percy.yml (like widths, minHeight, enableJavaScript, etc.) were not being passed to PercyDOM.serialize(). Only per-snapshot options were used. Now merges both, with per-snapshot options taking priority. Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
This PR is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.percy.yml(likewidths,minHeight,enableJavaScript, etc.) were not being passed toPercyDOM.serialize()Changes
data['config']['snapshot']withkwargsbefore callingget_serialized_dom()andcapture_responsive_dom()Test plan
.percy.ymlconfig options are applied during DOM serialization🤖 Generated with Claude Code