test: re-add comprehensive.html regression fixture#2260
Open
pankaj443 wants to merge 4 commits into
Open
Conversation
Restore the comprehensive regression test page that was removed in PR #2239. The fixture exercises fonts, pseudo-class CSS rules, and other web features used by the regression suite. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The <video> carried a header-only base64 mp4 <source> (a 32-byte ftyp box with no moov/mdat). It's unplayable and serves no purpose for this fixture, whose goal is exercising video *poster* handling — serialize- video.js skips elements that already have a poster attribute, so the source was never part of any capture path. The stub engages the browser media pipeline, which the upgraded (v143- era) Firefox renderer handles differently than v126, causing the Comprehensive snapshot to fail rendering on Firefox. Removing the source leaves networkState=EMPTY (no load attempt) in both Chromium and Firefox while keeping the poster — the actual thing under test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Replace the header-only/truncated base64 mp4 (a 32-byte ftyp box with no moov/mdat) with a complete, spec-valid minimal mp4 (ftyp+free+mdat+moov). The original stub engaged the media pipeline in a way the upgraded Firefox 146 renderer (percy-renderer #1775, FF 139.0.4 -> 146.0.1) failed to render, causing the Comprehensive snapshot to time out on Firefox. The discovery/serialization path is identical across CLI versions (verified: old v126 and new v143 CLI both timed out), so the fixture must carry media the renderer can actually parse. Using a valid source keeps the data-URI video serialization path under test (serialize-video / serializeBase64) while no longer hanging the renderer. Locally the video now reports networkState=IDLE with no decode error in both Chromium and Firefox (the stub reported NO_SOURCE). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rishigupta1599
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-adds
test/regression/pages/comprehensive.html, which was removed in #2239 ("test: remove unused comprehensive.html regression fixture").The fixture is restored verbatim from its state prior to deletion (added originally in #2145). It exercises fonts (
@font-face), pseudo-class CSS rules (:hover,:focus), and other web features used by the regression suite.Why
Re-adding the comprehensive regression fixture so it's available again for the regression test pages.
🤖 Generated with Claude Code