Skip to content

Adopt @percona/peak-ui - #5732

Open
fabio-silva wants to merge 2 commits into
mainfrom
migrate-to-peak-ui-lib
Open

Adopt @percona/peak-ui#5732
fabio-silva wants to merge 2 commits into
mainfrom
migrate-to-peak-ui-lib

Conversation

@fabio-silva

@fabio-silva fabio-silva commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Move from @percona/percona-ui to @percona/peak-ui

Summary by CodeRabbit

  • Documentation
    • Updated UI guidance and setup instructions to reference the Peak UI package.
  • Chores
    • Migrated the PMM interface to the renamed Peak UI package across components, themes, forms, tables, dialogs, and configuration.
    • Updated testing and development tooling references to ensure consistent package integration.
    • No user-facing behavior or functionality changes.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The PR renames PMM UI guidance, dependency declarations, tooling references, tests, and source imports from @percona/percona-ui to @percona/peak-ui. Runtime component behavior and public declarations remain unchanged.

Changes

Peak UI package migration

Layer / File(s) Summary
Package and tooling migration
AGENTS.md, ui/AGENTS.md, ui/apps/pmm/README.md, ui/apps/pmm/package.json, ui/apps/pmm/vite.config.ts, ui/apps/pmm/vitest.config.ts
Documentation, dependency version, local linking instructions, and test/build configuration now use @percona/peak-ui.
Shared UI imports and test setup
ui/apps/pmm/src/App.tsx, ui/apps/pmm/src/components/..., ui/apps/pmm/src/hooks/theme.ts, ui/apps/pmm/src/utils/testWrapper.tsx
Shared components, theme APIs, and test setup now import from @percona/peak-ui.
Alerting UI imports
ui/apps/pmm/src/pages/alerting/...
Alerting pages, details, raw data, and tables now use the renamed package.
RTA UI imports
ui/apps/pmm/src/pages/rta/...
Realtime overview, tables, details, and session modals now use the renamed package.
Settings and supporting page imports
ui/apps/pmm/src/pages/help-center/..., ui/apps/pmm/src/pages/settings/..., ui/apps/pmm/src/pages/update-clients/UpdateClients.tsx, ui/apps/pmm/src/pages/updates/...
Supporting pages and settings forms now import UI components and types from @percona/peak-ui.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

  • percona/pmm#5731: Updates overlapping UI files and imports while also replacing custom icons.

Suggested reviewers: matejkubinec, mattiasimonato, ademidoff

Poem

A rabbit changed each package name,
From Percona UI to Peak UI fame.
Imports hop, and configs align,
While components keep their same design.
No runtime carrot went astray.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the migration but omits the required ticket number, feature build, API documentation checklist, and related-work section. Add the template sections with the ticket number, feature build, API documentation status, and related work references if applicable.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: migration from the existing UI package to @percona/peak-ui.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch migrate-to-peak-ui-lib

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.41%. Comparing base (31318c7) to head (485cb67).
⚠️ Report is 91 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5732      +/-   ##
==========================================
+ Coverage   43.59%   45.41%   +1.82%     
==========================================
  Files         415      418       +3     
  Lines       43134    43334     +200     
==========================================
+ Hits        18804    19682     +878     
+ Misses      22454    21707     -747     
- Partials     1876     1945      +69     
Flag Coverage Δ
admin 34.96% <ø> (+0.17%) ⬆️
agent 51.10% <ø> (+2.05%) ⬆️
managed 44.98% <ø> (+2.00%) ⬆️
vmproxy 72.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fabio-silva
fabio-silva marked this pull request as ready for review August 4, 2026 15:59
@fabio-silva
fabio-silva requested review from a team as code owners August 4, 2026 15:59
@fabio-silva
fabio-silva requested review from JiriCtvrtka, ademidoff, matejkubinec and mattiasimonato and removed request for a team, JiriCtvrtka and ademidoff August 4, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant