Skip to content

PMM-15092: fix InnoDB Row Reads legendFormat - #5721

Open
mattiasimonato wants to merge 2 commits into
mainfrom
PMM-15092-fix-innodb-row-reads-legend
Open

PMM-15092: fix InnoDB Row Reads legendFormat#5721
mattiasimonato wants to merge 2 commits into
mainfrom
PMM-15092-fix-innodb-row-reads-legend

Conversation

@mattiasimonato

@mattiasimonato mattiasimonato commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Ticket number: PMM-15092

Feature build: SUBMODULES-4501

  • Remove unused {{ operation }} from the InnoDB Row Reads legendFormat on MySQL InnoDB Details.
  • The query filters operation="read" and groups only by service_name, so that template never resolves and breaks some downstream graph consumers.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the MySQL InnoDB dashboard legend to display the clearer static label “Rows.”

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The MySQL InnoDB dashboard panel legend now displays the static label Rows instead of including the operation variable.

Changes

MySQL InnoDB dashboard

Layer / File(s) Summary
Static Rows legend
dashboards/dashboards/MySQL/MySQL_InnoDB_Details.json
The panel legend changed from Rows {{ operation }} to Rows.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: fabio-silva, matejkubinec, nailya

Poem

A rabbit hops through dashboard rows,
And trims the legend where the label grows.
“Rows,” says the hare,
“Clean and clear there!”
Then quietly back to the burrow it goes.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the InnoDB Row Reads legend fix and includes the relevant ticket number.
Description check ✅ Passed The description includes the ticket number, feature build, change summary, and technical rationale; optional sections do not require additional content.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Fix failing CI checks
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch PMM-15092-fix-innodb-row-reads-legend

Comment @coderabbitai help to get the list of available commands.

@mattiasimonato
mattiasimonato marked this pull request as ready for review July 31, 2026 14:13
@mattiasimonato
mattiasimonato requested review from a team and Nailya as code owners July 31, 2026 14:13
@mattiasimonato
mattiasimonato requested review from fabio-silva and matejkubinec and removed request for a team July 31, 2026 14:13
@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.03%. Comparing base (31318c7) to head (8553f99).
⚠️ Report is 87 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5721      +/-   ##
==========================================
- Coverage   43.59%   37.03%   -6.56%     
==========================================
  Files         415      215     -200     
  Lines       43134     7168   -35966     
  Branches        0      585     +585     
==========================================
- Hits        18804     2655   -16149     
+ Misses      22454     4317   -18137     
+ Partials     1876      196    -1680     
Flag Coverage Δ
admin 34.96% <ø> (+0.17%) ⬆️
agent ?
managed ?
unittests 41.29% <ø> (?)
vmproxy ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants