[DOC] PMM Mysql AHI Efficiency advisor check

[catalinaadam]

Ticket number: PMM-0

Feature build: SUBMODULES-0

If this PR adds, removes or alters one or more API endpoints, please review and update the relevant API documentation as well:

• API Docs updated

If this PR is related to other PRs, contributions, or ongoing work in this or other repositories, please reference them here:

• Links to related work items (optional).

[Tusamarco]

LGTM

[ademidoff]

@copilot Can you check if the "Major" alert level is used in our code base?

[Copilot]

"Major" is not a supported severity level. The supported levels (defined in managed/pi/common/severity.go) are: emergency, alert, critical, error, warning, notice, info, debug. Passing "major" to ParseSeverity() would silently return Unknown (0).

Fixed in the latest commit by replacing "major" with "error" in both the check YAML (mysql_ahi_efficiency_performance_basic_check.yml) and the documentation.

[ademidoff]

@Tusamarco Could you please review this fix? Do we want the severity to be set to "error" or "critical" in this case?

[Tusamarco]

in my opinin:

• Info: AHI is working normally, or it's disabled.
• Notice: contention is building up and starting to affect performance.
• Warning: contention is high enough that the AHI is likely hurting more than helping. Increase AHI partitions or disable AHI altogether.

[Tusamarco]

@ademidoff

[ademidoff]

OK, we can change the severity to "warning" on line 123, but then there will be no difference between two branches: this one and the one above.

I think we need to refactor the code here, since not all branches are present.

[catalinaadam]

@ademidoff @Tusamarco - Mariana Bonsignore needs this topic live by the end of the month. do you think we could refactor the code and merge by then?

[it-percona-cla]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ catalinaadam
❌ Copilot
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.92%. Comparing base (31318c7) to head (f71bde3).
⚠️ Report is 69 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5686      +/-   ##
==========================================
+ Coverage   43.59%   44.92%   +1.32%     
==========================================
  Files         415      218     -197     
  Lines       43134    27834   -15300     
==========================================
- Hits        18804    12504    -6300     
+ Misses      22454    13979    -8475     
+ Partials     1876     1351     -525     

Flag	Coverage Δ
admin	?
agent	?
managed	44.92% <ø> (+1.94%)	⬆️
vmproxy	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.