PMM-7 Fix PMM-T2227 tarball upgrade version check - #1135
Closed
cursor[bot] wants to merge 3 commits into
Closed
Conversation
Use CLIENT_IMAGE version instead of pmm-submodules VERSION file, quote tarball URLs, and harden agent restart after upgrade. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: davi.travaglia <davi.travaglia@percona.com>
Fix docker run invocation on pmm-client images and wait for tarball_client container to be running before setup. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: davi.travaglia <davi.travaglia@percona.com>
Use the client docker image version for --version checks when CLIENT_VERSION is a tarball URL, matching PMM-T2227 expectations. Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: davi.travaglia <davi.travaglia@percona.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
FB
CLI / Integration / Genericfailed on PMM-T2227 because the test compared the post-upgradepmm-admin versionagainstpmm-submodules/v3/VERSION(e.g.3.9.0/3.9.1) instead of the tarball/client image actually under test. FB and dev tarballs report feature-branch versions (e.g.3.9.0-v3-*or3.9.0-PMM-*), so the assertion failed even when upgrade succeeded.How
CLIENT_IMAGEviadocker run --entrypoint pmm-admin ... --version --json.pmm3_client_install_tarball.sh.docker network connectargument order and harden pmm-agent restart/PID checks after upgrade.tarball_clientto be running before install steps; remove the container on completion.Triggered by FB failure on Percona-Lab/pmm-submodules#4505 (
CLI tests Generic).