Skip to content

fix: keep UTF-8 in panes after a Homebrew update restarts the app - #893

Merged
penso merged 1 commit into
penso:mainfrom
detunized:fix/relaunch-locale
Oct 29, 2026
Merged

penso merged 1 commit into
penso:mainfrom
detunized:fix/relaunch-locale

Conversation

@detunized

Copy link
Copy Markdown
Contributor

Summary

Fixes #891.

After a Homebrew update, the relaunch helper ran open with LC_ALL=C. The restarted app inherited it and passed it to the Herdr server, so every pane ran in the C locale and UTF-8 broke. The helper now sets only PATH. A new relaunch test checks that open gets no locale.

A Herdr server started before the fix keeps LC_ALL=C until it restarts.

Validation

  • cargo test -p herdr-updater --lib brew: passed. The new test fails without the fix (LC_ALL=C).
  • just ci: not run locally, left to GitHub CI

Manual QA

  • Let an installed Homebrew build update and restart, restart the Herdr server, and check that env in a pane has no LC_ALL=C

The relaunch helper ran `open` with LC_ALL=C. The restarted app inherited
it and passed it to the Herdr server, so every pane ran in the C locale.
@detunized
detunized requested a review from penso as a code owner October 29, 2026 13:29
@greptile-apps

greptile-apps Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Removes the forced LC_ALL=C from the Homebrew restart helper while keeping the cleared environment and explicit PATH.

  • Homebrew restarts no longer pass a forced C locale to the app.

Reviews (1) · Last reviewed commit: "fix: keep UTF-8 in panes after a Homebre..." · Reviewed by Greptile

@penso
penso merged commit f5d0e1e into penso:main Oct 29, 2026
23 checks passed
@detunized
detunized deleted the fix/relaunch-locale branch October 29, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panes lose UTF-8 after a Homebrew update restarts the app

2 participants