Repository navigation
fix: keep UTF-8 in panes after a Homebrew update restarts the app - #893
Merged
Merged
Conversation
The relaunch helper ran `open` with LC_ALL=C. The restarted app inherited it and passed it to the Herdr server, so every pane ran in the C locale.
[Medium impact] The PR appears safe to merge. SummaryRemoves the forced
Reviews (1) · Last reviewed commit: "fix: keep UTF-8 in panes after a Homebre..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #891.
After a Homebrew update, the relaunch helper ran
openwithLC_ALL=C. The restarted app inherited it and passed it to the Herdr server, so every pane ran in the C locale and UTF-8 broke. The helper now sets onlyPATH. A new relaunch test checks thatopengets no locale.A Herdr server started before the fix keeps
LC_ALL=Cuntil it restarts.Validation
cargo test -p herdr-updater --lib brew: passed. The new test fails without the fix (LC_ALL=C).just ci: not run locally, left to GitHub CIManual QA
envin a pane has noLC_ALL=C