Repository navigation
fix(palette): title Go To agent rows with the pane name the sidebar shows - #875
Merged
Merged
Conversation
…hows Go To found an agent by its pane name but titled the row only "Claude", so the match showed none of the text that was searched. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
 [Low impact] The PR appears safe to merge. SummaryGo To agent rows now show the agent name followed by the pane name used in the sidebar.
Reviews (1) · Last reviewed commit: "fix(palette): title Go To agent rows wit..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #835. Go To now finds an agent by its pane name, but the row is still titled only with the agent kind ("Claude"). So when you search a pane name, the match has no visible text in common with the query, and nothing in the row is highlighted.
This titles agent rows the way the sidebar does: the agent name, then the pane name from the sidebar's own
pane_namehelper, joined with " · ". For example, "Claude · shop-cash-eng question". The pane name is the Rename label, otherwise the agent's title. An agent with neither keeps the plain "Claude" title. Because the pane name is now in the row title, it is highlighted and ranks as a name match.Validation
just ci, run withGIT_CONFIG_GLOBAL=/dev/nullfor the reason given in fix(palette): find agents in Go To by the titles and pane name the sidebar shows #835.go_to_titles_agents_with_the_pane_name_the_sidebar_showsfails before the change and passes after it. Two existing tests now expect the fixture agent's row to read "Claude · shell".Manual QA
claudeas agents. I renamed one agent's pane toshop-cash-eng question, pressed Cmd-P, and typed the name. The top row read "claude · shop-cash-eng question", with the matching words highlighted.