feat: Add support for sequences - #24
Draft
SimonIT wants to merge 2 commits into
Draft
Conversation
peanutbother
requested changes
Jul 18, 2026
| //! The following serde types are **not** supported: | ||
| //! | ||
| //! - Sequences (Vec, arrays, etc.) | ||
| //! - Deserializing sequences (Vec, arrays, etc.) |
Owner
There was a problem hiding this comment.
this PR adds the feature to de/ser sequences so this line should be removed or changed to "Deserializing nested sequences"
| //! - Unit structs | ||
| //! | ||
| //! Attempting to serialize or deserialize these types will result in an error. | ||
| //! Attempting to deserialize these types will result in an error. |
Owner
There was a problem hiding this comment.
as I understand de/ser is both meant because your PR just changes how the parser structures the tree. with my other comment regarding this it, the wording should stay or did I miss something there?
Owner
|
this is a great addition, please rebase your PR so I can start testing and merge it afterwards |
Author
|
Thanks for taking a quick look! I have edited the comments. Please test everything thoroughly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #23
What do you think?