fix: Make return_url and cancel_url optional in application_context for subscriptions#789
Open
danqzq wants to merge 2 commits intopaypal:mainfrom
Open
fix: Make return_url and cancel_url optional in application_context for subscriptions#789danqzq wants to merge 2 commits intopaypal:mainfrom
return_url and cancel_url optional in application_context for subscriptions#789danqzq wants to merge 2 commits intopaypal:mainfrom
Conversation
…of subscription (fixes paypal#716)
🦋 Changeset detectedLatest commit: c320218 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
Author
|
bump |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes #716
See also: #238
A TypeScript error occurs when using the PayPal JS SDK Buttons integration for subscriptions without specifying
return_urlandcancel_urlinapplication_context, even though previous guidance states these fields are not required/recommended for the JS SDK flow.Error:
See #716 for minimal reproduction steps
Change
Updated the type definition for
application_contextto makereturn_urlandcancel_urloptional.