-
Notifications
You must be signed in to change notification settings - Fork 147
chore(many): design guidelines assets #4498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
9cd3d75
a687ac3
57489be
4d09778
12cfd35
8b46983
357029e
875ce1b
6e0d7fe
9480a74
02d9601
456911b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I know this image is replicating the existing one, but I feel like the current one is longer than it needs to be. Could we try making the image more of a horizontal spread? I made a new frame in figma called "alert-types-erin" (which you can just rename) for what I was thinking, but I'm open to feedback if we want to keep this format |
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For this one, can you change the field label for the 2 errored inputs to be "Version" and "Region"? Just to align with the link names used in the error |
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this one is also missing annotations! |
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the figma file and it looks like the token marker annotations were outside of the frame, so they didn't export with this image. I fixed it in figma, so if you re-export and upload then I think you'll be good to go