better install: streamline GPU detection and pip configuration#28
Open
Apophis3158 wants to merge 2 commits into
Open
better install: streamline GPU detection and pip configuration#28Apophis3158 wants to merge 2 commits into
Apophis3158 wants to merge 2 commits into
Conversation
- Centralize GPU arch→URL mapping in detect_gpu.py (arch_index_suffix) - Add PIP env vars (REQUIRE_VIRTUALENV, NO_WARN_SCRIPT_LOCATION, QUIET) - Fix echo [!] escaping for enabledelayedexpansion ([^^!]) - Remove redundant >nul 2>&1 from pip commands for better error visibility - Update bitsandbytes wheel URL to official continuous-release - Add python_env/ to .gitignore
Author
|
Run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried
install.batand found some issues:Necessary
In TheRock/pytorch/README it says
So
/v2is tests passed stabled releases and/v2-stagingshould not be used.Run
pip install rocm[devel,libraries]first will always install the latest build likerocm-sdk 7.13.0a20260414, but then runpip install torchmight only gettorch 7.13.0a20260409, this will uninstall therocm-sdk 7.13.0a20260414you just installed and installrocm-sdk 7.13.0a20260409instead.pip install torch torchaudio torchvisionfirst, it will auto collect needed rocm-sdkcoreandlibraries, then runpip install rocm[devel,libraries]will add the matchingdevelWhen installation failed, the script prints
Check the error messages above for details.but there was no error message.>nul 2>&1echo !won't print because ofsetlocal enabledelayedexpansionset.echo ^^!instead.User might have set
PIP_REQUIRE_VIRTUALENV=truefor safety, and block script running,QOL
bitsandbytes supports Windows ROCm CI now [ROCm] Windows workflow for creating wheels with ROCm 7.2.1 support bitsandbytes-foundation/bitsandbytes#1915 so we could use the nightly build via https://github.com/bitsandbytes-foundation/bitsandbytes/releases/tag/continuous-release_main.
detect_gpu.pyalready got a lot of GPU information so we can just add anarch_indexmap to make better use of those.Use
PIP_NO_WARN_SCRIPT_LOCATIONandPIP_QUIETin script for quick environment installation debug.