Repository navigation
feat(truapi): refuse a request in a version the host does not know #1650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
db0b05d
feat(truapi): refuse a request in a version the host does not know
Mikelle 5a87148
docs(changeset): reword the request versions release note
Mikelle 17419e5
docs(truapi): reword the unsupported version note in the README
Mikelle 4a3b108
docs(truapi): reword the unsupported version helper's doc comment
Mikelle e30b202
refactor(truapi): name the dispatcher's decoding wrapper apart from t…
Mikelle 28332f7
fix(truapi): let a Cancel that beats a version refusal answer Cancelled
Mikelle ba960d5
refactor(truapi): settle a reserved call's answer in one match
Mikelle 26dc498
test(truapi): drop a comment that restates the test request types
Mikelle 3e79392
docs(truapi): reword the UnsupportedVersion protocol error docs
Mikelle b3b108b
docs(truapi): reword the malformed frame error encoder's docs
Mikelle 9c62a77
docs(truapi): reword the strict decoding note on protocol errors
Mikelle 1d350f6
refactor(truapi): read every known protocol error version and variant…
Mikelle 7f8e42e
refactor(truapi): check protocol error indexes one level at a time
Mikelle 01e2160
Merge remote-tracking branch 'origin/main' into feat/request-versions
Mikelle 647af19
docs: reword the request versions note in the README
Mikelle 959cab1
refactor(truapi): let the codec decide which protocol errors the clie…
Mikelle 8875ff2
fix(truapi): address review of the unsupported version refusal
Mikelle d8da55c
test(truapi): reword the unknown protocol error payload comments
Mikelle 2e251f5
docs(truapi): reword the unknown protocol error comment in the client
Mikelle d5cafd0
docs(truapi): shorten the refused version warning's doc comment
Mikelle f0de99c
docs(truapi): reword the Versioned encoding rule
Mikelle dda046d
Merge remote-tracking branch 'origin/main' into feat/unsupported-vers…
Mikelle 335bee4
Merge branch 'main' into feat/unsupported-version-error
Mikelle 65f9082
Merge branch 'main' into feat/unsupported-version-error
Mikelle 9eec928
Merge branch 'main' into feat/unsupported-version-error
Mikelle f9bdf34
Merge branch 'main' into feat/unsupported-version-error
Mikelle a88a8ca
Merge branch 'main' into feat/unsupported-version-error
Mikelle 58f1fe7
Merge branch 'main' into feat/unsupported-version-error
Mikelle a976778
Merge branch 'main' into feat/unsupported-version-error
Mikelle e14e635
Merge branch 'main' into feat/unsupported-version-error
Mikelle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@parity/truapi": minor | ||
| "@parity/truapi-host": minor | ||
| --- | ||
|
|
||
| If a product sends a request in a version the host doesn't know, the host rejects it with an `UnsupportedVersion` error instead of failing to decode it, and the call fails as `Unsupported`. Older hosts still answer `MalformedFrame`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.