Repository navigation
Conversation
…ound renewal Adapt #1490 onto the Media integration branch. Product grants are provisioned on demand, so the renewal ledger must not receive or warn about them.
Contributor
Bundle size reportCompared with
WebAssembly modules
Changed files (46)
Commit: 45ad51f |
Contributor
|
CI Status: not green, 5 items need attention.
All job results
Signing credentials: failure as of 2026-10-21, a release may fail Commit |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Media integration still asks the renewal ledger to retain product statement-store allowances. The ledger rejects these by design because product grants are provisioned on demand, so each successful allocation emits a misleading warning.
Change
Adapt #1490 onto the current
feat/media-on-jam-seitytip. Remove the impossible renewal registration and keep the upstream warning regression test. No published API or wire shape changes.Verification
cargo test -p truapi --all-features issuing_an_allowance_does_not_register_it_for_background_renewalThe branch has existing repository-wide formatting debt unrelated to these two files; this patch matches #1490 exactly.