Skip to content

fix(truapi): stop registering product statement allowances for background renewal - #1625

Open
replghost wants to merge 1 commit into
feat/media-on-jam-seityfrom
integrate/media-statement-renewal-fix
Open

replghost wants to merge 1 commit into
feat/media-on-jam-seityfrom
integrate/media-statement-renewal-fix

Conversation

@replghost

Copy link
Copy Markdown
Contributor

Problem

The Media integration still asks the renewal ledger to retain product statement-store allowances. The ledger rejects these by design because product grants are provisioned on demand, so each successful allocation emits a misleading warning.

Change

Adapt #1490 onto the current feat/media-on-jam-seity tip. Remove the impossible renewal registration and keep the upstream warning regression test. No published API or wire shape changes.

Verification

  • cargo test -p truapi --all-features issuing_an_allowance_does_not_register_it_for_background_renewal
  • 1 passed

The branch has existing repository-wide formatting debt unrelated to these two files; this patch matches #1490 exactly.

…ound renewal

Adapt #1490 onto the Media integration branch. Product grants are provisioned on demand, so the renewal ledger must not receive or warn about them.
@replghost
replghost requested a review from a team as a code owner October 22, 2026 02:19
@replghost replghost added the ci:no-changeset Changes no published artifact, so the changeset check passes without one label Oct 22, 2026
@github-actions github-actions Bot added area:core Touches the Rust core under rust/crates and removed ci:no-changeset Changes no published artifact, so the changeset check passes without one labels Oct 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Bundle size report

Compared with main at dd78483.

Raw Gzip Brotli
truapi-host 8.85 MiB (+831.4 KiB, +10.1%) 6.06 MiB (+357.7 KiB, +6.1%) 5.68 MiB (+266.1 KiB, +4.8%)
truapi-provider 4.03 MiB (-11 B) 1.27 MiB (+7 B) 959.8 KiB (-1.1 KiB, -0.1%)
truapi 6.79 MiB (+181.5 KiB, +2.7%) 984.1 KiB (+46.7 KiB, +5.0%) 803.2 KiB (+36.2 KiB, +4.7%)
trinity-stack removed removed removed
Total 19.68 MiB (+450.5 KiB, +2.3%) 8.30 MiB (+178.9 KiB, +2.2%) 7.40 MiB (+114.7 KiB, +1.5%)

WebAssembly modules

Raw Gzip Brotli
truapi-host/wasm/web/truapi_server_bg.wasm 3.49 MiB (+569.4 KiB, +19.0%) 1.32 MiB (+303.2 KiB, +29.0%) 1003.4 KiB (+219.5 KiB, +28.0%)
truapi-host/wasm/web/truapi_verifiable_bg.wasm 4.89 MiB 4.64 MiB (+6 B) 4.61 MiB (-58 B)
truapi-provider/truapi_provider_bg.wasm 3.99 MiB (-11 B) 1.26 MiB (+3 B) 952.1 KiB (-1.1 KiB, -0.1%)
Changed files (46)
Raw Gzip Brotli
truapi-host/wasm/web/truapi_server_bg.wasm 3.49 MiB (+569.4 KiB, +19.0%) 1.32 MiB (+303.2 KiB, +29.0%) 1003.4 KiB (+219.5 KiB, +28.0%)
trinity-stack/wasm/trinity_stack_bg.wasm removed removed removed
truapi/explorer/codegen/versions/0.26.0/types.js removed removed removed
truapi/explorer/codegen/types.js 388.6 KiB (+156.9 KiB, +67.7%) 56.7 KiB (+24.5 KiB, +75.9%) 44.3 KiB (+18.5 KiB, +72.0%)
truapi/playground/codegen/truapi-dts.js 439.5 KiB (+139.1 KiB, +46.3%) 79.7 KiB (+27.7 KiB, +53.1%) 62.8 KiB (+20.9 KiB, +49.8%)
truapi-host/web/browser-media-backend.js (new) 81.7 KiB 17.2 KiB 14.6 KiB
truapi/explorer/codegen/versions/0.26.0/services.js removed removed removed
truapi/playground/codegen/services.js 143.1 KiB (+39.5 KiB, +38.1%) 23.6 KiB (+7.8 KiB, +49.5%) 19.7 KiB (+6.4 KiB, +48.5%)
truapi/generated/types.js 100.9 KiB (+34.4 KiB, +51.9%) 12.7 KiB (+4.5 KiB, +55.0%) 10.7 KiB (+3.7 KiB, +53.2%)
truapi-host/browser-receiving-worker.js (new) 33.8 KiB 6.6 KiB 5.8 KiB
truapi/generated/client.js 106.9 KiB (+32.5 KiB, +43.6%) 17.6 KiB (+6.3 KiB, +55.4%) 14.5 KiB (+5.1 KiB, +53.9%)
trinity-stack/wasm/trinity_stack.js removed removed removed
truapi/jam-peer-transport.js (new) 29.7 KiB 6.6 KiB 5.7 KiB
truapi-host/wasm/web/truapi_server.js 80.3 KiB (+22.2 KiB, +38.2%) 12.6 KiB (+2.0 KiB, +18.9%) 10.8 KiB (+1.7 KiB, +18.5%)
truapi-host/web/native-chat-files.js (new) 20.5 KiB 4.6 KiB 4.0 KiB
truapi-host/web/create-worker-host-runtime.js 74.0 KiB (+20.0 KiB, +37.1%) 15.0 KiB (+3.2 KiB, +27.1%) 13.0 KiB (+2.7 KiB, +26.4%)
truapi-host/generated/host-callbacks.js 25.0 KiB (+13.7 KiB, +120.6%) 6.9 KiB (+3.3 KiB, +89.7%) 5.9 KiB (+2.8 KiB, +90.5%)
truapi-host/web/native-chat-media.js (new) 12.0 KiB 3.3 KiB 2.9 KiB
truapi/notification-envelope.js (new) 10.7 KiB 3.2 KiB 2.8 KiB
truapi/generated/wire-decode.js 40.3 KiB (+10.6 KiB, +35.6%) 4.1 KiB (+989 B, +30.7%) 3.4 KiB (+828 B, +30.7%)
truapi-host/worker-runtime.js 49.0 KiB (+10.5 KiB, +27.4%) 11.5 KiB (+1.7 KiB, +17.7%) 10.1 KiB (+1.5 KiB, +17.6%)
truapi/jam-peer-transport-cert.js (new) 9.0 KiB 3.4 KiB 3.0 KiB
truapi/notification-container.js (new) 7.9 KiB 2.3 KiB 2.0 KiB
trinity-stack/dist/index.js removed removed removed
truapi-host/adapter-support.js 10.1 KiB (+6.7 KiB, +195.2%) 2.9 KiB (+1.6 KiB, +117.6%) 2.5 KiB (+1.3 KiB, +110.7%)
truapi-host/browser-receiving.js (new) 6.6 KiB 1.9 KiB 1.7 KiB
truapi-host/wallet-allowances.js (new) 6.5 KiB 1.7 KiB 1.5 KiB
truapi-host/browser-receiving-transport.js (new) 6.1 KiB 2.2 KiB 1.9 KiB
truapi-host/generated/host-callbacks-adapter.js 12.9 KiB (+5.8 KiB, +81.7%) 2.7 KiB (+1.1 KiB, +70.0%) 2.3 KiB (+989 B, +70.2%)
truapi-host/worker-local-identity.js (new) 5.7 KiB 1.8 KiB 1.5 KiB
truapi-host/generated/worker-callbacks.js 12.4 KiB (+5.1 KiB, +70.1%) 2.3 KiB (+816 B, +53.5%) 1.9 KiB (+671 B, +53.6%)
truapi/generated/wire-table.js 12.4 KiB (+3.2 KiB, +34.4%) 2.0 KiB (+394 B, +23.8%) 1.6 KiB (+306 B, +23.5%)
truapi-host/locale.js (new) 1.9 KiB 689 B 622 B
truapi-host/runtime.js 2.3 KiB (+1.6 KiB, +215.6%) 855 B (+419 B, +96.1%) 692 B (+361 B, +109.1%)
truapi/client.js 34.4 KiB (+1.3 KiB, +3.8%) 8.3 KiB (+305 B, +3.7%) 7.1 KiB (+262 B, +3.7%)
truapi/development.js (new) 942 B 508 B 446 B
trinity-stack/dist/wasm.js removed removed removed
truapi-host/worker-permission-authorization.js 3.2 KiB (+674 B, +26.1%) 432 B (+55 B, +14.6%) 387 B (+81 B, +26.5%)
truapi-host/worker-dispatch.js 1.8 KiB (+467 B, +33.1%) 525 B (+125 B, +31.3%) 446 B (+100 B, +28.9%)
truapi-host/worker-protocol.js 3.7 KiB (+282 B, +8.1%) 1.4 KiB (+157 B, +12.2%) 1.1 KiB (+114 B, +10.7%)
truapi/explorer/versions.js 5.5 KiB (-215 B, -3.7%) 832 B (-19 B, -2.2%) 560 B (-7 B, -1.2%)
truapi-host/web/index.js 328 B (+183 B, +126.2%) 177 B (+63 B, +55.3%) 152 B (+34 B, +28.8%)
truapi/sandbox.js 13.5 KiB (+153 B, +1.1%) 4.2 KiB (+68 B, +1.6%) 3.6 KiB (+54 B, +1.5%)
truapi-host/index.js 80 B (+50 B, +166.7%) 80 B (+30 B, +60.0%) 67 B (+33 B, +97.1%)
truapi/index.js 591 B (+34 B, +6.1%) 293 B (+8 B, +2.8%) 224 B (+4 B, +1.8%)
truapi-provider/truapi_provider_bg.wasm 3.99 MiB (-11 B) 1.26 MiB (+3 B) 952.1 KiB (-1.1 KiB, -0.1%)

Commit: 45ad51f

@github-actions

Copy link
Copy Markdown
Contributor

CI Status: not green, 5 items need attention.

  • rust: failure
  • ts-host: failure
  • host-wasm: failure
  • explorer: cancelled
  • changeset-guard: failure
All job results
job result
android-bindings success
bundle-size success
changes success
changeset-guard failure
cli-package success
codegen success
e2e skipped
explorer cancelled
headless-install success
host-android-bindings success
host-android-detekt success
host-wasm failure
ios-bindings success
ios-swift success
licenses success
playground success
provider-android-bindings skipped
release-guard success
rust failure
ts-client success
ts-debugger success
ts-host failure
wasm-provider success
workflow-lint skipped

Signing credentials: failure as of 2026-10-21, a release may fail

Commit 45ad51f1 · run log

@TarikGul TarikGul added size:M Pull requests only. 200 to 499 lines changed status:waiting-on-review Ready for a reviewer labels Oct 30, 2026
@TarikGul TarikGul added size:S Pull requests only. 50 to 199 lines changed and removed size:M Pull requests only. 200 to 499 lines changed labels Nov 18, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core Touches the Rust core under rust/crates size:S Pull requests only. 50 to 199 lines changed status:waiting-on-review Ready for a reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants