Skip to content
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions .claude/skills/labels/SKILL.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
---
name: labels
description: Label pull requests and issues in this repository, and add, rename or retire a label. Use when opening a pull request, filing an issue, asking for an app build, marking work as blocked, triaging, or when a task mentions a label. Labels are defined as code in .github/labels.yml, so a label is never created by hand.
---

# Labels

[docs/labels.md](../../../docs/labels.md) owns the system: every family, what each label means, and what is automatic. Read it for anything this file does not answer.

## Opening a pull request

- Do not add `area:` or `size:` labels. A pull request carries no area, and `pr-triage.yml` sets the size from the lines changed.
- Do not set `status:waiting-on-review`; `pr-triage.yml` sets it when a pull request opens ready, or leaves draft, with no status.
- Add a `ci:` label only to get what it runs, and only when the change needs it: `ci:ios-simulator` or `ci:ios-device` for the iOS app, `ci:android-device` for an APK, `ci:android-emulator-tests`, `ci:host-playground-e2e`. Each one starts macOS or emulator jobs on every later push, so do not add them by default.
- Add `ci:no-changeset` only when the change ships nothing, as docs/RELEASE_PROCESS.md describes.
- To label the issue the pull request finishes, write `Closes #N` in the body. The issue gets its `area:` labels when the pull request merges.

## While it is open

- Keep one `status:` label, named for who acts next: `status:waiting-on-author` after requesting changes, `status:ready-to-merge` once approved, `status:blocked` when something else has to land first, with a comment saying what.
- Add a `needs:` label when work is blocked on something other than code: `needs:spec`, `needs:decision` or `needs:UI`. On a pull request, a `needs:` label or `status:blocked` fails `Label gate`, so remove it once resolved.

## Filing an issue

- Add `area:` labels for what it touches, and a `spa:` label when a product needs it.
- Type, status, priority and target date are issue fields, not labels.

## Adding, renaming or retiring a label

- Never create, rename or delete a label with `gh label` or the web UI. Edit `.github/labels.yml` in a pull request; `scripts/sync-labels.py` applies it when the pull request merges.
- Name it `family:value`, lowercase with hyphens, in an existing family. Give it a color, a description saying when to use it, a `target` and an `addedBy`.
- To rename, put the old name under `previously`; the label stays on everything that carries it. To delete, move it under `retired` with a reason. A label whose replacement is not decided goes under `pending`.
- If a workflow, script, template or doc names the label, change it in the same pull request, so the label and its users land together. `rg` for the old name across `.github`, `scripts`, `.claude` and the docs.
- Run `python3 scripts/sync-labels.py` to see the plan against the live labels. It only reads. Never pass `--apply`; the push to main does that.
- `diagnosis-report` keeps its name: deployed copies of the playground open issues with it.
8 changes: 4 additions & 4 deletions .claude/skills/rfc-issue/SKILL.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: rfc-issue
description: Write the tracking issue for an RFC — a short Description / Motivation / Requirements / Tasks body labeled `rfc`, written either from an RFC document already in review or from notes when no RFC exists yet. Use for "open a tracking issue for this RFC", "create issues for the open RFCs", or when an idea needs an RFC that nobody has drafted.
description: Write the tracking issue for an RFC — a short Description / Motivation / Requirements / Tasks body labeled `area:rfc`, written either from an RFC document already in review or from notes when no RFC exists yet. Use for "open a tracking issue for this RFC", "create issues for the open RFCs", or when an idea needs an RFC that nobody has drafted.
argument-hint: [RFC PR number, RFC path, or a description of the idea]
---

Expand All @@ -18,7 +18,7 @@ remote permission` becomes `RFC: Credential-endpoint remote permission`. The num
belongs to the document: it changes when the document is renumbered and it collides
between RFCs in flight.

**Label** — `rfc`.
**Label** — `area:rfc`.

**Body** — four sections, nothing else:

Expand Down Expand Up @@ -103,8 +103,8 @@ an RFC amending `product-manifest.md` gets its own issue, but a second PR agains
same amendment does not.

```bash
gh issue list --label rfc --state all --limit 100
gh issue create --title "RFC: <Title>" --body-file <path> --label rfc
gh issue list --label area:rfc --state all --limit 100
gh issue create --title "RFC: <Title>" --body-file <path> --label area:rfc
```

## Related
Expand Down
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Reviewers requested from the paths a pull request touches.
#
# The same roots drive labelling in .github/labeler.yml. The two are different
# The same roots drive the areas in .github/areas.yml. The two are different
# formats and cannot be one file, so scripts/check-path-routing.py holds them to
# the same set and CI runs it.
#
Expand Down
1 change: 0 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE/design.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

- [ ] Added or updated file in `docs/design/`
- [ ] Included YAML frontmatter with title, type, status, author, created, and pr fields
- [ ] Added label: `design-doc`

### Changes

Expand Down
1 change: 0 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE/feature.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

- [ ] Added `docs/features/short-descriptive-name.md` with completed frontmatter
- [ ] Updated `docs/features/_index.md` with a link to the new proposal
- [ ] Added labels: `feature-request`, `proposal`

### Use Cases

Expand Down
1 change: 0 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE/rfc.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
- [ ] Added `docs/rfcs/<slug>.md` (no number — CI assigns one on merge)
- [ ] Filled all RFC sections (Summary, Motivation, Detailed Design, Drawbacks, Alternatives, Unresolved Questions)
- [ ] Updated Rust traits in `rust/crates/truapi/`
- [ ] Added label: `rfc`

### Motivation

Expand Down
45 changes: 45 additions & 0 deletions .github/areas.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
# Which paths belong to which area. issue-areas.yml reads this to label the
# issues a pull request closes; new pull requests carry no area themselves. Every
# label here is defined in .github/labels.yml.
#
# The same paths decide who is asked to review in .github/CODEOWNERS. The two
# files are different formats, so scripts/check-path-routing.py holds them to the
# same set of roots and CI runs it. Change one and the check tells you about the
# other.
#
# Globs: `**` matches across directories, `*` within one. A glob with no slash,
# like `*.md`, matches at the repository root only.
#
# Keep it flat: a quoted label, then one quoted glob per line. issue-areas.yml
# reads it without a YAML parser.

"area:rfc":
Comment thread
TarikGul marked this conversation as resolved.
Resolved
- "docs/rfcs/**"

"area:docs":
- "docs/**"
- "*.md"

"area:ci":
- ".github/workflows/**"
- ".github/actions/**"

"area:js":
- "js/**"
- "playground/**"
- "explorer/**"

# The core reaches every host at once, so a change here is the most expensive
# one to get wrong.
"area:core":
- "rust/crates/**"

# The hosts are apart rather than together. An iOS-only change and an
# Android-only change are reviewed by different people and break differently.
"area:ios":
- "hosts/ios/**"
- "ios/**"

"area:android":
- "hosts/android/**"
- "android/**"
4 changes: 4 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ version: 2
updates:
- package-ecosystem: github-actions
directory: /
# Set explicitly, because its default ecosystem label is not one
# .github/labels.yml defines.
labels:
- dependencies
schedule:
interval: weekly
cooldown:
Expand Down
54 changes: 0 additions & 54 deletions .github/labeler.yml

This file was deleted.

Loading
Loading