Repository navigation
Conversation
Adds the generic host-owned Media service: v01 Media wire types and methods 0-10 at prototype wire trait 218, RemotePermission::Calling, host-core media sessions, groups, signaling and backend boundaries, platform media capabilities, browser media backend for the JS host, native Android/iOS media backends, and playground media specs. Squashes: - wip(media): preserve implementation before approved upstream integration - fix(media): keep receive-only sessions on device revocation; wait for backend session before placing pictures - refactor(media): move Media to prototype wire trait 218
Media session_subscribe waited for MediaSignaling to start, so a cold light client ended the stream with NotConnected before any snapshot. Subscribing now only probes the backend and starts observation. One background connector owns signaling: it starts it, drives its events, and after a failure or loss restarts it with backoff (500 ms doubling to 10 s) until the runtime closes. Each binding is still fenced by the current authority and a new epoch. Mutations that need signaling wait for the binding within their operation deadline and skip the pending backoff.
…er starts The core admits a participant, and the product sees it, before the call handshake asks the backend to create its peer. The browser backend re-checked remote surfaces against its own peer table and rejected those rectangles with InvalidHandle, so Vox showed "Pictures not placed" while a call was negotiating. The core already validates participant handles; the backend now queues the rectangle and renders it once the peer media is live, like the Android and iOS backends. Unknown handles still fail in the core.
Always construct RTCPeerConnection with iceTransportPolicy relay and drop the optional override. Never signal a non-relay candidate, neither as an IceCandidate event nor embedded in a description. The playground media specs now run against a loopback coturn relay.
Lock navigator.mediaDevices.enumerateDevices on the instance and every prototype with the same NotAllowedError as capture.
Size the event queue for a full 256-statement page plus control headroom, and admit only messages a lagging consumer has room for. Unadmitted packets are not replay-recorded, so a later delivery still succeeds and the endpoint no longer ends every call with ConnectivityLost.
A waiter parked while a signaling attempt runs found no backoff to wake, so the attempt's failure still waited a full backoff. The retry request is now sticky and consumed by the next backoff wait.
…layer Merge feat/media-sessions (Media service, prototype wire trait 218, on #709 a78944c) into the integration revision 795a408 that #291 vendors. - RemotePermission keeps JamPeers at positional index 5 and appends Calling at 6 (TS codegen encodes variants positionally). - PermissionAuthorizationRequest keeps the deployed ProfileDisclosure at codec index 6 and moves Calling to index 7. - Platform super-trait, runtime adapters and wasm wiring carry both the Profile and Media platforms; JamPeerSession is retained. - Codegen keeps the receiving layer's Option<codec>/Option<bytes> argument form ahead of Media's generic Option fallback, and its receiving test passes Media's private_media flag. - The mock-permission arm count covers both JamPeers and Calling (16).
Preserve Media's generalized optional callback codecs and exports. Drop a timing-dependent wording assertion; structured cancellation and SSO cleanup coverage remain.
attachmentIsolated() probed the product frame with a discarded `frame.contentWindow.document` read inside try/catch. dotli's production build tells rolldown/oxc that property reads have no side effects, which deletes the read and leaves the check always "not isolated", so attach() failed with SurfaceUnavailable on paseo.fyi. Use contentDocument === null, whose value is used and which is null exactly for cross-origin and opaque sandboxed documents. The new media spec runs the decision in Chromium against tsc, esbuild --minify and dotli-configured rolldown builds.
Contributor
|
This pull request touches an app, which is not built by default. Add a label for each build you want:
Each starts as soon as it is added and follows the branch from then on. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Bundle size reportCompared with
WebAssembly modules
Changed files (71)
Commit: bd5a58c |
Contributor
|
CI Status: not green, 3 items need attention.
All job results
Signing credentials: valid as of 2026-11-13 Commit |
A Statement Store submit that outlives its budget (e.g. while the light client stalls) or loses its transport may still have been accepted. The caller then failed its outgoing link with ConnectivityLost while the callee rang, accepted, and waited for a Commit that never came (Unanswered). Invite, Accept and Commit are idempotent at the receiver, so retry them (up to four attempts, one second apart, fenced again after the wait) while the link would still send them; other messages keep the existing failure path.
# Conflicts: # rust/crates/truapi/src/wasm.rs
# Conflicts: # rust/crates/truapi-client/src/generated.rs # rust/crates/truapi/src/host_core.rs # rust/crates/truapi/src/wasm.rs
# Conflicts: # rust/crates/truapi-client/src/generated.rs
# Conflicts: # rust/crates/truapi/src/host_core.rs
# Conflicts: # rust/crates/truapi/src/host_core.rs
…gration JAM peer listener and chunked transport contract (trait 111 methods 7-9) that the validator guest needs for inbound duties. # Conflicts: # rust/crates/truapi-client/src/generated.rs # rust/crates/truapi/src/lib.rs
Brings the validator custody layer (trait 112, RemotePermission::Validator) onto #1217. RemotePermission::Validator is encoded at index 112, as on the TrUAPI 0.30 line, because this branch already uses positional index 6 for Calling. Validator custody stays outside trusted-product defaults: a trusted product still gets NotDetermined for Validator and must ask. Permission denials revoke validator custody before and after persisting the decision, alongside the existing Media revocation. Mobile hosts have no protected custody and deny the permission. Conflicted files keep this branch's formatting; only the merged lines change. Generated outputs are regenerated.
replghost
added a commit
to paritytech/dotli-community
that referenced
this pull request
Nov 14, 2026
Re-vendors @parity/truapi and @parity/truapi-host from paritytech/trinity-user-agents#1217 at 9608ac911, which merges the JAM peer transport duty contract and validator custody (trait 112). The browser host has no protected custody: the core reports custody as unsupported and the permission callback denies Validator.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integration layer that adds the host-owned Media service (#838, RFC #839) to the JamPeerTransport-on-Seity line (#1011), so the dotli layer that deploys paseo.fyi can vendor one host with Seity, JamPeerTransport and Media.
The integration began with a
--no-ffmerge:795a40820: the chore(deploy): Seity layer + JamPeerTransport (#1001 + #1010) #1011 revision that dotli fix(host): cover Dotli signing regressions #291 currently vendorsd8105398b: the Media feature layer (feat/media-sessions, on feat: add Chat v2 product authority operations #709a78944c23)It now also integrates the Tommy platform fixes from #1216 and subsequent Media updates. Source feature layers remain separate; this PR assembles them above #1011.
Media in one paragraph
Products get calling without touching WebRTC. The host owns capture, signaling (sealed packets over the Statement Store), relay-only ICE through TURN, and picture compositing. Products see opaque session, participant and operation handles, authoritative snapshots, peer product-account keys, and submit picture rectangles. No SDP, ICE candidates, IP addresses, device ids or media bytes reach product memory. Calling consent is a separate permission scoped to product, network and account; camera and microphone keep their own device consent.
Wire
Mediais prototype wire trait 218, methods 0–10. Sequential trait 20 is Contacts upstream; 218 keeps this unreviewed service clear of the range assigned in merge order. Only the trait byte moves when it is allocated for real.RemotePermissionorder:…, StatementSubmit, JamPeers, Calling(JamPeers keeps 5, already deployed on paseo.fyi).PermissionAuthorizationRequestorder:…, ProfileDisclosure (6), Calling (7).Initial Media qualification (historical)
cargo test -p truapi --lib: 1615 passed (media 28, permission 103, jam 10, profile 31, calling 7)bun test: truapi-host 371, truapi 921, js/container 126795a40820(unnecessary_lazy_evaluationsin capabilities/platform.rs, twotoo_many_argumentsin the receiving code); none in Media codeDraft: not for merge; it exists so the paseo.fyi integration layer has a pushed host revision and review surface.
Current integration qualification
8e735637702df560eb3af7853301d06cf1c942fb; client and production/testing signing-host WASM retain the verified44b87fea6fbe430589bb53c31a3e38b620ad5374build. The intervening changes do not change Rust/WASM. All 110 host archive files and 143 client archive files match the browser vendor, allowing only its declared local client dependency override.Known qualification limits: the exact legacy TrUAPI 0.7 storage probe still times out; no claim is made that historical #263 is fixed. Physical-device theme appearance, fully-quit native notification activation, and Tommy’s historical paired-device identity case are not covered by the simulator/local-browser evidence.