[xcm-emulator] Decouple the AccountId type from AccountId32#1458
Merged
Conversation
NachoPal
added
the
T14-system_parachains
bkontur
reviewed
Sep 8, 2023
bkontur
approved these changes
Sep 8, 2023
bkontur
left a comment
bkontur
left a comment
Contributor
There was a problem hiding this comment.
lgtm, just one nit with type renaming
joepetrowski
approved these changes
Sep 28, 2023
acatangiu
approved these changes
Sep 28, 2023
gilescope
approved these changes
Sep 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1381
Originally from: paritytech/cumulus#3037