Skip to content

[xcm-emulator] Improve hygiene and clean up#1301

Merged
NachoPal merged 13 commits into
masterfrom
nacho/xcm-emulator-hygiene
Sep 1, 2023
Merged

[xcm-emulator] Improve hygiene and clean up#1301
NachoPal merged 13 commits into
masterfrom
nacho/xcm-emulator-hygiene

Conversation

@NachoPal

@NachoPal NachoPal commented Aug 30, 2023

Copy link
Copy Markdown
Contributor

Solves: paritytech/cumulus#2985

Improved hygiene for the xcm-emulator macros and clean up of unnecessary dependancies.

@NachoPal NachoPal added R0-no-crate-publish-required The change does not require any crates to be re-published. T10-tests This PR/Issue is related to tests. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. labels Aug 30, 2023
@NachoPal

NachoPal commented Aug 30, 2023

Copy link
Copy Markdown
Contributor Author

bot fmt

@command-bot

command-bot Bot commented Aug 30, 2023 •
edited
Loading

Copy link
Copy Markdown

@NachoPal https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3491771 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-e7605000-fe02-4449-98a2-29794c72d382 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot

command-bot Bot commented Aug 30, 2023

Copy link
Copy Markdown

@NachoPal Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3491771 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3491771/artifacts/download.

@paritytech paritytech deleted a comment from command-bot Bot Aug 30, 2023
@NachoPal

NachoPal commented Aug 30, 2023

Copy link
Copy Markdown
Contributor Author

bot fmt

@command-bot

command-bot Bot commented Aug 30, 2023 •
edited
Loading

Copy link
Copy Markdown

@NachoPal https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3492532 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-07b7c2ec-bafc-49d4-ac45-60713621e67b to cancel this command or bot cancel to cancel all commands in this pull request.

@NachoPal
NachoPal requested review from bkontur and gilescope August 30, 2023 10:41
@command-bot

command-bot Bot commented Aug 30, 2023

Copy link
Copy Markdown

@NachoPal Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3492532 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3492532/artifacts/download.

@bkchr

bkchr commented Aug 30, 2023

Copy link
Copy Markdown
Member

@NachoPal the test-rustdoc is still failing.

@NachoPal
NachoPal merged commit 241601b into master Sep 1, 2023
@NachoPal
NachoPal deleted the nacho/xcm-emulator-hygiene branch September 1, 2023 10:44
ordian added a commit that referenced this pull request Sep 1, 2023
@ordian
Merge branch 'master' into s0me0ne/candidate-session-index
40e3da9 
* master: (25 commits)
  fix typos (#1339)
  Use bandersnatch-vrfs with locked dependencies ref (#1342)
  Bump bs58 from 0.4.0 to 0.5.0 (#1293)
  Contracts: `seal0::balance` should return the free balance (#1254)
  Logs: add extra debug log for negative rep changes (#1205)
  Added short-benchmarks for cumulus (#1183)
  [xcm-emulator] Improve hygiene and clean up (#1301)
  Bump the known_good_semver group with 1 update (#1347)
  Renames API (#1186)
  Rename `polkadot-parachain` to `polkadot-parachain-primitives` (#1334)
  Add README to project root (#1253)
  Add environmental variable to track decoded instructions (#1320)
  Fix polkadot-node-core-pvf-prepare-worker build with jemalloc (#1315)
  Sassafras primitives (#1249)
  Restructure `dispatch` macro related exports (#1162)
  backing: move the min votes threshold to the runtime (#1200)
  Bump zstd from 0.11.2+zstd.1.5.2 to 0.12.4 (#1326)
  Remove `substrate_test_utils::test` (#1321)
  remove disable-runtime-api (#1328)
  [ci] add more jobs for pipeline cancel, cleanup (#1314)
  ...
ordian added a commit that referenced this pull request Sep 7, 2023
@ordian
Merge branch 'master' into ao-polkadot-use-pinning-api
d3e00e0 
* master: (25 commits)
  Markdown linter (#1309)
  Update `fmt` file and some authors (#1379)
  Bump the known_good_semver group with 1 update (#1375)
  Bump proc-macro-warning from 0.4.1 to 0.4.2 (#1376)
  feat: add futures api to `TransactionPool` (#1348)
  Ensure cumulus/bridges is ignored by formatter and run it (#1369)
  substrate: chain-spec paths corrected in zombienet tests (#1362)
  contracts: Update to wasmi 0.31 (#1350)
  [improve docs]: Template pallet (#1280)
  [xcm-emulator] Unignore cumulus integration tests (#1247)
  Fix wrong ref counting (#1358)
  Use cached session index to obtain executor params (#1190)
  fix typos (#1339)
  Use bandersnatch-vrfs with locked dependencies ref (#1342)
  Bump bs58 from 0.4.0 to 0.5.0 (#1293)
  Contracts: `seal0::balance` should return the free balance (#1254)
  Logs: add extra debug log for negative rep changes (#1205)
  Added short-benchmarks for cumulus (#1183)
  [xcm-emulator] Improve hygiene and clean up (#1301)
  Bump the known_good_semver group with 1 update (#1347)
  ...
@crystalin crystalin mentioned this pull request Oct 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkontur bkontur bkontur approved these changes
+1 more reviewer
@gilescope gilescope gilescope approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. R0-no-crate-publish-required The change does not require any crates to be re-published. T10-tests This PR/Issue is related to tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NachoPal @bkchr @gilescope @bkontur