Fixes for many Static Analysis Reports

.github/workflows/static-analysis.yml

@@ -0,0 +1,86 @@
+# JULEA - Flexible storage framework
+# Copyright (C) 2026 Jan Frase
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Lesser General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+name: static-analysis.yml
+on: [push, pull_request]
+defaults:
+  run:
+    shell: bash
+
+jobs:
+  # This job is responsible for running Codechecker.
+  code-checker:
+    name: Code checker
+    runs-on: ubuntu-24.04
+    timeout-minutes: 60
+    env:
+      JULEA_SPACK_DIR: /julea-dependencies
+
+
+    steps:
+      # First, checkout julea.
+      - name: Checkout
+        uses: actions/checkout@v6
+        with:
+          persist-credentials: false
+          show-progress: false
+
+      # Get the dependencies.
+      - name: Install dependencies
+        run: |
+          sudo apt update
+          sudo apt --yes --no-install-recommends install meson ninja-build pkgconf libglib2.0-dev libbson-dev libfabric-dev libgdbm-dev liblmdb-dev libsqlite3-dev libleveldb-dev libmongoc-dev libmariadb-dev librocksdb-dev libfuse3-dev libopen-trace-format-dev librados-dev
+
+      # Then, generate compile_commands.json.
+      - name: Generate compile_commands.json
+        env:
+          CC: clang
+        run: |
+          . scripts/environment.sh
+          meson setup bld
+
+      # Install CodeChecker, gcc and cppcheck.
+      - name: Install CodeChecker
+        run: |
+          pip install codechecker
+          sudo apt install --yes --no-install-recommends cppcheck gcc 
+
+      - name: Install Infer
+        run: |
+          VERSION=1.3.0; \
+          curl -sSL "https://github.com/facebook/infer/releases/download/v$VERSION/infer-linux-x86_64-v$VERSION.tar.xz" \
+          | sudo tar -C /opt -xJ && \
+          sudo ln -s "/opt/infer-linux-x86_64-v$VERSION/bin/infer" /usr/local/bin/infer
+
+      # Run the analysis.
+      - name: Run CodeChecker
+        # Since we already have ~100 warnings, i have disabled the sensitive checks for now.
+        # Should we ever run out of warnings, feel free to enable them again :D
+        run: CodeChecker analyze ./bld/compile_commands.json -o results --ctu || true #--enable sensitive
+
+      # Parse the results and generate an HTML report.
+      - name: Generate HTML report
+        run: |
+          # The parse command returns with exit code 2 if it finds any bugs.
+          # Thus, we ignore the exit code with "|| true", to avoid failing the workflow.
+          CodeChecker parse --export html --output ./reports_html ./results || true
+
+      # Lastly, upload the results to the CI.
+      - name: Upload results
+        uses: actions/upload-artifact@v7.0.1
+        with:
+          name: "CodeChecker Bug Reports"
+          path: ./reports_html

backend/db/mysql.c

@@ -74,7 +74,7 @@ j_sql_finalize(gpointer backend_db, void* _stmt, GError** error)
 	g_return_val_if_fail(backend_db != NULL, FALSE);
 	g_return_val_if_fail(_stmt != NULL, FALSE);
 
-	if (wrapper->stmt && (status = mysql_stmt_close(wrapper->stmt)))
+	if (wrapper->stmt && (status = (unsigned char)mysql_stmt_close(wrapper->stmt)))
 	{
 		g_set_error(error, J_BACKEND_SQL_ERROR, J_BACKEND_SQL_ERROR_FINALIZE, "sql finalize failed error was  (%d):'%s'", status, mysql_stmt_error(wrapper->stmt));
 		goto _error;
@@ -477,7 +477,7 @@ j_sql_step(gpointer backend_db, void* _stmt, gboolean* found, GError** error)
 	{
 		if (wrapper->param_count_in)
 		{
-			if ((status = mysql_stmt_bind_param(wrapper->stmt, wrapper->bind_in)))
+			if ((status = (unsigned char)mysql_stmt_bind_param(wrapper->stmt, wrapper->bind_in)))
 			{
 				g_set_error(error, J_BACKEND_SQL_ERROR, J_BACKEND_SQL_ERROR_STEP, "sql step failed error was  (%d):'%s'", status, mysql_stmt_error(wrapper->stmt));
 				goto _error;
@@ -486,7 +486,7 @@ j_sql_step(gpointer backend_db, void* _stmt, gboolean* found, GError** error)
 
 		if (wrapper->param_count_out)
 		{
-			if ((status = mysql_stmt_bind_result(wrapper->stmt, wrapper->bind_out)))
+			if ((status = (unsigned char)mysql_stmt_bind_result(wrapper->stmt, wrapper->bind_out)))
 			{
 				g_set_error(error, J_BACKEND_SQL_ERROR, J_BACKEND_SQL_ERROR_STEP, "sql step failed error was  (%d):'%s'", status, mysql_stmt_error(wrapper->stmt));
 				goto _error;

benchmark/benchmark.c

@@ -198,7 +198,7 @@ j_benchmark_run_one(BenchmarkRun* run)
 		{
 			g_autofree gchar* size = NULL;
 
-			size = g_format_size((gdouble)run->bytes / elapsed_time);
+			size = g_format_size((guint64)((gdouble)run->bytes / elapsed_time));
 			g_print(" (%s/s)", size);
 		}
 
@@ -311,7 +311,12 @@ main(int argc, char** argv)
 	};
 
 	// Explicitly enable UTF-8 since functions such as g_format_size might return UTF-8 characters.
-	setlocale(LC_ALL, "C.UTF-8");
+	g_autofree const char* local_result = setlocale(LC_ALL, "C.UTF-8");
+	if (local_result == NULL)
+	{
+		g_warning("Failed to set locale!");
+		return 1;
+	}
 
 	context = g_option_context_new(NULL);
 	g_option_context_add_main_entries(context, entries, NULL);

benchmark/db/common.c

@@ -38,13 +38,13 @@
 #define FLOAT_FACTOR (3.1415926)
 
 static char*
-_benchmark_db_get_identifier(gint64 i)
+helper_fn_benchmark_db_get_identifier(gint64 i)
 {
 	return g_strdup_printf("%x-benchmark-%ld", (guint32)(i * SIGNED_FACTOR % N_MODULUS), i);
 }
 
 static JDBSchema*
-_benchmark_db_prepare_scheme(gchar const* namespace, gboolean use_batch, gboolean use_index_all, gboolean use_index_single, JBatch* batch, JBatch* delete_batch)
+helper_fn_benchmark_db_prepare_scheme(gchar const* namespace, gboolean use_batch, gboolean use_index_all, gboolean use_index_single, JBatch* batch, JBatch* delete_batch)
 {
 	gboolean ret;
 	g_autoptr(GError) b_s_error = NULL;
@@ -132,7 +132,7 @@ _benchmark_db_prepare_scheme(gchar const* namespace, gboolean use_batch, gboolea
 }
 
 static void
-_benchmark_db_insert(BenchmarkRun* run, JDBSchema* scheme, gchar const* namespace, gboolean use_batch, gboolean use_index_all, gboolean use_index_single, gboolean use_timer)
+helper_fn_benchmark_db_insert(BenchmarkRun* run, JDBSchema* scheme, gchar const* namespace, gboolean use_batch, gboolean use_index_all, gboolean use_index_single, gboolean use_timer)
 {
 	gboolean ret;
 	g_autoptr(JBatch) delete_batch = NULL;
@@ -150,7 +150,7 @@ _benchmark_db_insert(BenchmarkRun* run, JDBSchema* scheme, gchar const* namespac
 		g_assert_null(scheme);
 		g_assert_nonnull(run);
 
-		b_scheme = _benchmark_db_prepare_scheme(namespace, use_batch, use_index_all, use_index_single, batch, delete_batch);
+		b_scheme = helper_fn_benchmark_db_prepare_scheme(namespace, use_batch, use_index_all, use_index_single, batch, delete_batch);
 		g_assert_nonnull(b_scheme);
 
 		j_benchmark_timer_start(run);
@@ -172,7 +172,7 @@ _benchmark_db_insert(BenchmarkRun* run, JDBSchema* scheme, gchar const* namespac
 			gint64 i_signed = ((i * SIGNED_FACTOR) % CLASS_MODULUS) - CLASS_LIMIT;
 			guint64 i_usigned = ((i * USIGNED_FACTOR) % CLASS_MODULUS);
 			gdouble i_float = i_signed * FLOAT_FACTOR;
-			g_autofree gchar* string = _benchmark_db_get_identifier(i);
+			g_autofree gchar* string = helper_fn_benchmark_db_get_identifier(i);
 			g_autoptr(JDBEntry) entry = j_db_entry_new(b_scheme, &b_s_error);
 			g_assert_null(b_s_error);