Repository navigation
🧹 chore: run dagger call with --cloud - #40
Merged
Merged
Conversation
Appends the global `--cloud` flag to every `dagger call` invocation in `.github/workflows/`, so CI runs on Dagger Cloud provisioned engines/machines. - Each Dagger step already supplies `DAGGER_CLOUD_TOKEN`, so no environment changes are needed. - The flag is placed at the end of each command, after all module/function flags, matching the existing `dagger call test --silent --cloud` convention.
jpmcb
marked this pull request as ready for review
September 24, 2026 22:21
|
| --repo="${{ github.repository }}" \ | ||
| check-pull-request \ | ||
| --number "${{ github.event.pull_request.number }}" | ||
| --number "${{ github.event.pull_request.number }}" --cloud |
There was a problem hiding this comment.
Fork PR checks require Cloud token
When a pull request comes from a fork, GitHub does not provide DAGGER_CLOUD_TOKEN to this workflow. Adding --cloud makes this check require that token to start, so it fails before validating the PR. The Linear magic-word check on line 61 has the same problem. Both checks need a way to run without the Cloud token.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/pr.yaml
Line: 36
Comment:
**Fork PR checks require Cloud token**
When a pull request comes from a fork, GitHub does not provide `DAGGER_CLOUD_TOKEN` to this workflow. Adding `--cloud` makes this check require that token to start, so it fails before validating the PR. The Linear magic-word check on line 61 has the same problem. Both checks need a way to run without the Cloud token.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👨🏼
Local DeepSeek fanout.
Refs PCC-1489
🤖
Appends the global
--cloudflag to everydagger callinvocation in.github/workflows/, so CI runs on Dagger Cloud provisioned engines/machines.DAGGER_CLOUD_TOKEN, so no environment changes are needed.dagger call test --silent --cloudconvention.