Skip to content

🧹 chore: run dagger call with --cloud - #40

Merged
jpmcb merged 1 commit into
mainfrom
ci/dagger-cloud
Sep 24, 2026
Merged

jpmcb merged 1 commit into
mainfrom
ci/dagger-cloud

Conversation

@jpmcb

@jpmcb jpmcb commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

👨🏼

Local DeepSeek fanout.

Refs PCC-1489

🤖

Appends the global --cloud flag to every dagger call invocation in .github/workflows/, so CI runs on Dagger Cloud provisioned engines/machines.

  • Each Dagger step already supplies DAGGER_CLOUD_TOKEN, so no environment changes are needed.
  • The flag is placed at the end of each command, after all module/function flags, matching the existing dagger call test --silent --cloud convention.

Appends the global `--cloud` flag to every `dagger call` invocation in `.github/workflows/`, so CI runs on Dagger Cloud provisioned engines/machines.

- Each Dagger step already supplies `DAGGER_CLOUD_TOKEN`, so no environment changes are needed.
- The flag is placed at the end of each command, after all module/function flags, matching the existing `dagger call test --silent --cloud` convention.
@jpmcb jpmcb changed the title ci: run dagger call with --cloud 🧹 chore: run dagger call with --cloud Sep 24, 2026
@jpmcb
jpmcb marked this pull request as ready for review September 24, 2026 22:21
@jpmcb
jpmcb merged commit a9f302a into main Sep 24, 2026
6 of 8 checks passed
@jpmcb
jpmcb deleted the ci/dagger-cloud branch September 24, 2026 22:21
@linear-code

linear-code Bot commented Sep 24, 2026

Copy link
Copy Markdown

PCC-1489

@greptile-apps

greptile-apps Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

This PR is not safe to merge until the PR checks can run when the Cloud token is unavailable to fork-originated pull requests.

Findings

  1. P1 Fork PR checks require Cloud token ▶
Fix with agent prompt
### Issue 1
.github/workflows/pr.yaml:36
When a pull request comes from a fork, GitHub does not provide `DAGGER_CLOUD_TOKEN` to this workflow. Adding `--cloud` makes this check require that token to start, so it fails before validating the PR. The Linear magic-word check on line 61 has the same problem. Both checks need a way to run without the Cloud token.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Summary

The PR adds --cloud to both Dagger-based PR checks so they run on Dagger Cloud engines.

  • Fork-originated pull requests cannot supply the Cloud token to this workflow, leaving both checks unable to start.

Reviews (1) · Last reviewed commit: "ci: run dagger call with --cloud"

Comment thread .github/workflows/pr.yaml
--repo="${{ github.repository }}" \
check-pull-request \
--number "${{ github.event.pull_request.number }}"
--number "${{ github.event.pull_request.number }}" --cloud

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Fork PR checks require Cloud token

When a pull request comes from a fork, GitHub does not provide DAGGER_CLOUD_TOKEN to this workflow. Adding --cloud makes this check require that token to start, so it fails before validating the PR. The Linear magic-word check on line 61 has the same problem. Both checks need a way to run without the Cloud token.

Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/pr.yaml
Line: 36

Comment:
**Fork PR checks require Cloud token**

When a pull request comes from a fork, GitHub does not provide `DAGGER_CLOUD_TOKEN` to this workflow. Adding `--cloud` makes this check require that token to start, so it fails before validating the PR. The Linear magic-word check on line 61 has the same problem. Both checks need a way to run without the Cloud token.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant