Skip to content

Subtler handling of malformed uv lockfiles. - #23763

Open
benjyw wants to merge 1 commit into
pantsbuild:mainfrom
benjyw:subtler_malformed_lockfile_handling
Open

benjyw wants to merge 1 commit into
pantsbuild:mainfrom
benjyw:subtler_malformed_lockfile_handling

Conversation

@benjyw

@benjyw benjyw commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

The behavior now matches that of pex lockfiles:

  • Without --sync we no longer error (on the diff computation), since we are overwriting the malformed file anyway.
  • With --sync we let uv do what it will with the malformed file, which currently means it errors, but with an error message that makes more sense.

Follow on from #23751

@benjyw benjyw added the release-notes:not-required [CI] PR doesn't require mention in release notes label Nov 12, 2026
@benjyw
benjyw requested a review from sureshjoshi November 12, 2026 21:06
The behavior now matches that of pex lockfiles:

- Without --sync we no longer error (on the diff computation),
  since we are overwriting the malformed file anyway.
- With --sync we let uv do what it will with the malformed file,
  which currently means it errors, but with an error message
  that makes more sense.
@benjyw
benjyw force-pushed the subtler_malformed_lockfile_handling branch from abd50dd to 958e7e5 Compare November 12, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:not-required [CI] PR doesn't require mention in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant