PERF: pass how=left to _factorize_keys in _left_join_on_index (#65160)#65199
Open
iabhi4 wants to merge 1 commit intopandas-dev:mainfrom
Open
PERF: pass how=left to _factorize_keys in _left_join_on_index (#65160)#65199iabhi4 wants to merge 1 commit intopandas-dev:mainfrom
iabhi4 wants to merge 1 commit intopandas-dev:mainfrom
Conversation
Contributor
Author
Thx for the review @rhshadrach , Appreciate it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes PERF: Specify
howwhen callingmerge._factorize_keyswhen possible #65160All code checks passed.
Added an entry in the latest
doc/source/whatsnew/v3.1.0.rstfile if fixing a bug or adding a new feature.I have reviewed and followed all the contribution guidelines
If I used AI to develop this pull request, I prompted it to follow
[AGENTS.md](http://agents.md/).Pass
how="left"to_factorize_keysin_left_join_on_index, enabling the hash join fast path (usingtable.lookup) for left joins on a right index with unique numeric keys andsort=False.Investigated all 6
_factorize_keyscall sites. The remaining 4 (get_join_indexersmulti-key,_get_multiindex_indexer, asof "by" keys,_get_join_keys) use return values as labels for further key combination and cannot use the hash join shortcut, which changes return semantics to join indexers withcount=-1.