TST: add _honors_copy_keyword to extension test base class#65179
Draft
jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
Draft
TST: add _honors_copy_keyword to extension test base class#65179jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
Conversation
Add a `_honors_copy_keyword` method to `BaseMissingTests` so that `test_fillna_readonly` can skip the `copy=False` assertion for EAs that always return new data regardless. This removes full test overrides in sparse, arrow, string, interval, and decimal test classes. Also skip the mutation check in `test_fillna_copy_frame` and `test_fillna_copy_series` for immutable dtypes, following the existing `_is_immutable` pattern in `test_ravel`/`test_transpose`. This removes two more sparse overrides. closes pandas-dev#63040 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jbrockmendel
added
the
Testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_honors_copy_keywordmethod toBaseMissingTestssotest_fillna_readonlyskips thecopy=Falseassertion for EAs that always return new data regardless. Removes full test overrides in sparse, arrow, string, interval, and decimal test classes.test_fillna_copy_frame/test_fillna_copy_seriesfor immutable dtypes, following the existing_is_immutablepattern intest_ravel/test_transpose. Removes two more sparse overrides.closes #63040
Test plan
🤖 Generated with Claude Code