Skip to content

REF: remove GeoDataFrame shim in _constructor_from_mgr #65175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jorisvandenbossche merged 2 commits into from
Apr 15, 2026
+0 −5
Merged

REF: remove GeoDataFrame shim in _constructor_from_mgr #65175

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14a2bd8
REF: remove GeoDataFrame shim and inline _constructor_expanddim_from_mgr
jbrockmendel Apr 11, 2026
cf2bc55
REV: restore _constructor_expanddim_from_mgr
jbrockmendel Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,11 +425,6 @@ def _constructor_from_mgr(self, mgr, axes) -> DataFrame:
# this check is slightly faster, benefiting the most-common case.
return df

elif type(self).__name__ == "GeoDataFrame":
# Shim until geopandas can override their _constructor_from_mgr
# bc they have different behavior for Managers than for DataFrames
return self._constructor(mgr)

# We assume that the subclass __init__ knows how to handle a
# pd.DataFrame object.
return self._constructor(df)
Expand Down
Loading