REF: IntervalArray _validate_setitem_value delegates to _validate_scalar#65174
Draft
jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
Draft
REF: IntervalArray _validate_setitem_value delegates to _validate_scalar#65174jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
Conversation
Consolidate duplicated validation logic between _validate_scalar and _validate_setitem_value to match the pattern used by DatetimeLikeArrayMixin and Categorical. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_validate_scalarand_validate_setitem_valueto match the pattern used byDatetimeLikeArrayMixinandCategorical_validate_scalarnow includes subdtype compatibility checks (resolving the TODO at the old line 1172), so both methods share a single code path for scalar validation_validate_setitem_valuedelegates to_validate_scalarfor scalars and_validate_listlikefor list-like valuesfillnacalls_validate_setitem_valueinstead of_validate_scalar, matching the standard pattern inNDArrayBackedExtensionArray__setitem__reordered to match the standardcheck_array_indexerthen_validate_setitem_valuepatternTest plan
pandas/tests/arrays/interval/(210 passed)pandas/tests/indexes/interval/(1657 passed)pandas/tests/extension/test_interval.py(525 passed)pandas/core/arrays/interval.py🤖 Generated with Claude Code