BUG: fix to_timedelta ignoring unit for mixed round/non-round floats#65170
Open
jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
Open
BUG: fix to_timedelta ignoring unit for mixed round/non-round floats#65170jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
jbrockmendel wants to merge 1 commit intopandas-dev:mainfrom
Conversation
…andas-dev#65150) Match the pattern used in tslib.pyx for numeric conversions: update creso first, then convert using creso as the output resolution. This ensures that when a resolution mismatch triggers a second pass, all numeric values (integers, round floats, non-round floats) are converted to the unified target resolution. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #65150
Summary
pd.to_timedelta([1.0, 1.01], unit="s")was treating1.0as 1 nanosecond instead of 1 secondarray_to_timedelta64, when a mix of round and non-round floats triggers a resolution-mismatch second pass, integers and round floats were converted usingint_reso(the unit's resolution) instead ofcreso(the target resolution), so their values were stored in the wrong unitstslib.pyxfor datetime conversions: updatecresofirst, then convert usingcresoas the output resolutionTest plan
🤖 Generated with Claude Code