PERF: Use optimized take path for non-nanosecond datetime64/timedelta64#65165
Open
jbrockmendel wants to merge 2 commits intopandas-dev:mainfrom
Open
PERF: Use optimized take path for non-nanosecond datetime64/timedelta64#65165jbrockmendel wants to merge 2 commits intopandas-dev:mainfrom
jbrockmendel wants to merge 2 commits intopandas-dev:mainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ke.py Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
datetime64[ns]andtimedelta64[ns]. Any other resolution fell through to the slow_take_nd_objectfallback instead of the optimized Cythontake_*_int64_int64functions._get_take_nd_function_cachedandtake_2d_multito routedtype.kind in "mM"to the int64 wrapper for all resolutions._view_wrapperfill value handling to use.view("i8")instead of hardcoding ns resolution (resolves existing FIXME).~4.6x faster for 1d take, ~1.5x for 2d take on non-ns datetime64/timedelta64 arrays.
Test plan
_get_take_nd_function_cachedreturns optimized function for non-ns resolutions (1d/2d, datetime64/timedelta64, us/ms/s)🤖 Generated with Claude Code