Skip to content

Respect pinned item order when focusing first item - #1425

Open
Canine89 wants to merge 1 commit into
p0deje:masterfrom
Canine89:focus-pinned-items-first
Open

Respect pinned item order when focusing first item#1425
Canine89 wants to merge 1 commit into
p0deje:masterfrom
Canine89:focus-pinned-items-first

Conversation

@Canine89

Copy link
Copy Markdown

Summary

  • Select the first visible history item when the popup becomes active instead of forcing the first unpinned item
  • Use the same first-visible selection behavior after clearing a search query
  • Add coverage for selecting the first item from the sorted history order

Testing

  • HOME=/tmp/maccy-build-home xcodebuild test -project Maccy.xcodeproj -scheme Maccy -only-testing:MaccyTests/SorterTests -derivedDataPath build-pr -clonedSourcePackagesDirPath /Users/canine89/src/Maccy/build/SourcePackages -disableAutomaticPackageResolution CODE_SIGN_IDENTITY=- CODE_SIGNING_ALLOWED=NO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants