fix(bm-server-components): preserve boolean type in OS install custom…#22742
Merged
Carlolis merged 1 commit intoApr 22, 2026
Merged
Conversation
Carlolis
requested review from
apelletant,
mhelhali-soufien,
qpavy,
rjamet-ovh and
tibs245
Carlolis
force-pushed
the
fix/PUBM-52327-fix-bool-OS-install
branch
3 times, most recently
from
2cf1bf3 to
f0b7311
Compare
mhelhali-soufien
approved these changes
Apr 20, 2026
qpavy
approved these changes
Apr 21, 2026
…izations getCustomizations() was converting all input values to strings via .toString(), causing enableLacpBonding to be sent as "true" instead of true. The API rejects this with "[customizations.enableLacpBonding] Given data is not valid for type boolean". ref: #PUBM-52327 Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]> Signed-off-by: Charles Ilieff <[email protected]>
Carlolis
force-pushed
the
fix/PUBM-52327-fix-bool-OS-install
branch
from
f0b7311 to
289878b
Compare
Carlolis
changed the base branch from
master
to
release/dedicated-fix-os-install
Carlolis
merged commit 032e5fe
into
release/dedicated-fix-os-install
13 of 14 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #PUBM-52327
getCustomizations() was converting all input values to strings via .toString(), causing enableLacpBonding to be sent as "true" instead of true. The API rejects this with "[customizations.enableLacpBonding] Given data is not valid for type boolean".
Description
Ticket Reference: #PUBM-52327
Additional Information