Repository navigation
fix: edit button styling and precise hit area - #46
Merged
Merged
Conversation
The edit affordance now renders with the shared button style and an icon in the emoji symbol set, and its hit area covers exactly the label instead of the whole row, so clicking beside it does nothing. ContentRow targets gain an optional clickable width for button-like rows; list rows keep full-row hit areas.
Owner
Author
|
Final report: merged as ff8de35. Edit affordance now uses the shared button style with an icon ([✏ edit] / [edit] in ASCII) and a hit area covering exactly the label — clicking beside it does nothing. ContentRow gained an opt-in precise target width, preserved across wrapped fragments per the review finding. 691 tests green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The edit affordance looked like a text link and, worse, clicking anywhere on its row triggered it.
It now renders exactly like the other buttons — accent background,
[✏ edit]with an icon in the emoji symbol set — and only the label itself is clickable.What Changed
ContentRowtargets gain an optional clickable width; button-like rows set it to their rendered label width, and hit-area registration clamps it to the viewport. List rows (links, settings) keep their full-row hit areas.button_styleand a newedit_buttonsymbol ([✏ edit]emoji,[edit]ASCII).Testing
cargo test: 691 pass, including new assertions that the hit area equals the label width, that a click beside the button does nothing while the label still opens the composer, and that the button carries the shared style.-D warnings/slophammer clean; capture manifests re-stamped (unauthenticated fixtures render no edit buttons, so frames are unchanged).Risks
Minimal — a rendering/hit-area change scoped to rows that opt into a precise width.