Repository navigation
feat!: consolidate the timeline into Overview - #44
Merged
Merged
Conversation
The Activity tab duplicated Overview's conversation with a second, manually-synced row builder, and the [details] affordance existed to jump into it. Both are gone: Overview is the single timeline, entry headers carry the focus anchor so same-resource comment links scroll to their entry in place, expansion covers reading full text, and permalinks stay reachable on expanded entries. Old sessions and --tab values naming activity fall back to Overview.
Clicking refresh in offline fixture mode left the deferred-refresh flag set, so a fixture reload fired a frame later and overwrote the skip message; the mouse smoke suite raced against it.
Owner
Author
|
Final report: merged as c3e5618. Overview is the single timeline; Activity tab, [details] rows, and the duplicate row builder are gone. Comment-anchor links scroll to the entry in place. Gates: 689 tests, coverage, slophammer, both capture suites re-recorded, in-diff mutants 0 missed, Codex review clean after the parser-error and 1-5 help fixes. One deliberate skip: no permalink affordance on short collapsed entries (expansion shows the url row) — any always-visible replacement would reintroduce the clutter this PR removes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Activity tab showed a subset of what Overview already shows, and the
[details]button existed mainly to jump into it.Both are removed: Overview is now the single timeline, and everything the pair did is covered by mechanisms that already exist.
Reading a long entry is
[more]/[less]expansion, comment permalinks appear on expanded entries, and clicking a same-resource comment link scrolls to that entry on Overview instead of switching tabs.This also deletes a second activity row builder that had to be kept in sync with Overview's by hand.
What Changed
One timeline, one row builder, five tabs.
Tab::Activityis gone: PRs show Overview/Commits/Checks/Files/Links, issues show Overview/Links. Number keys, arrows, and vim keys follow the shorter lists; help and README updated. Old sessions or--tab activityvalues fall back to Overview.activity_rows) and the[details]row are deleted. Overview's conversation entries now carry the focus anchor, sofocus_activity_url(same-resource comment links) expands and scrolls to the entry in place.Testing
Everything regenerated and green locally with exit codes checked individually (no pipelines masking failures).
cargo fmt --check,cargo check --all-targets,cargo clippy --all-targets --all-features -- -D warningscargo test: 689 tests pass; tab cycling/numbering, focus-to-Overview, and details-absence assertions updated or addedcargo llvm-cov --fail-under-lines 85: passescargo mutants --in-diff: 1 survivor (thecommitsparse arm), killed with an exhaustive tab-name parse test; CI runs the gate again1-6) — both fixedRisks
This intentionally removes UI; the risk is workflow breakage for anyone relying on the tab.
--tabvalues namingactivitysilently open Overview rather than erroring.[details]'s browser-open fallback for odd URLs is gone; permalinks remain reachable on expanded entries.