feat:add drawer, container, file-upload components#1813
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds designer bundle metadata for TinyDrawer, creates designer snippets for TinyContainer/TinyFileUpload/TinyDrawer, and registers all three components in app schema componentsMap entries. ChangesAdd component metadata for TinyDrawer, TinyContainer, and TinyFileUpload
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@designer-demo/public/mock/bundle.json`:
- Around line 620-625: 组件配置中 TinyContainer
被标记为非容器,这与它定义的多插槽(default/header/aside/footer)和布局行为不一致;在 mock/bundle.json 中找到
TinyContainer 的 "configure" 对象(包含 loop/condition/styles 字段)并将 "isContainer":
false 改为 "isContainer": true,以便设计器识别其容器能力并启用嵌套/投放交互,其他字段保留不变。
- Around line 269-289: The "高度" field in the JSON bundle is bound to the wrong
property key: change the object whose "label.text.zh_CN" is "高度" (currently
containing "property": "width", "defaultValue": "100vh", "description":
"设置抽屉的高度") so that its "property" value is "height" instead of "width" to ensure
the designer updates height rather than width.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: d660f719-0da4-48f7-8ecf-68a02fd210ba
📒 Files selected for processing (3)
designer-demo/public/mock/bundle.jsonmockServer/src/mock/get/app-center/v1/apps/schema/1.jsonmockServer/src/mock/get/app-center/v1/apps/schema/16.json
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit