Fix: check HTTP status in history.js fetch calls (#6282)#7016
Draft
JackieLin999 wants to merge 1 commit intoopenstreetmap:masterfrom
Draft
Fix: check HTTP status in history.js fetch calls (#6282)#7016JackieLin999 wants to merge 1 commit intoopenstreetmap:masterfrom
JackieLin999 wants to merge 1 commit intoopenstreetmap:masterfrom
Conversation
Member
|
That's an awful lot of code just to check for load errors - was an AI perhaps involved in writing this? I see there's also a lot of HTML being generated in javascript which we prefer to avoid where we can. |
| setListFetchData(data, url); | ||
|
|
||
| fetch(url.pathname + "?" + data) | ||
| .then(response => response.text()) |
Collaborator
There was a problem hiding this comment.
Here a short path would be
.then(response => {
if(!response.ok) {
throw new Error("Request failed. Got http code: " + response.status + " " + response.statusText);
}
return response.text();
})and a slim catch handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6282
Added HTTP status checking to the fetch calls in loadFirstChangesets
and loadMoreChangesets so that error responses (e.g. 504 gateway timeout)
are handled gracefully instead of being rendered as HTML in the history panel.